Skip to content

feat: support Flutter 3.32.0 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Conrad598
Copy link
Contributor

@Conrad598 Conrad598 commented May 27, 2025

Status

READY

Description

Fixes #96. This updates the override for Navigator.removeRouteBelow for its new signature in Flutter 3.32.0. This also updates the min flutter version in the pubspec.yaml to ^3.32.0 because the new override would fail to compile on previous versions.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced route removal to allow passing an optional result when removing a route below a specified anchor route.
  • Tests

    • Updated tests to align with the new route removal method signature.
  • Chores

    • Updated Flutter SDK version constraint to 3.32.0 in configuration and CI workflows.

@Conrad598 Conrad598 requested a review from a team as a code owner May 27, 2025 23:25
Copy link

coderabbitai bot commented May 27, 2025

"""

Walkthrough

The method signature for _MockNavigatorState.removeRouteBelow was updated to match the new Flutter 3.32.0 API, introducing a generic type parameter and an optional result argument. Corresponding test code was also updated to mock the new method signature with two arguments. Additionally, the Flutter SDK constraint in pubspec.yaml and the Flutter version in the CI workflow were updated to ^3.32.0.

Changes

File(s) Change Summary
lib/src/mock_navigator.dart Updated _MockNavigatorState.removeRouteBelow to use a generic type and an optional result param.
test/src/mock_navigator_test.dart Modified test mock setup to expect the new method signature with two arguments.
pubspec.yaml Updated Flutter SDK version constraint from ^3.29.0 to ^3.32.0.
.github/workflows/main.yaml Updated Flutter version in CI build matrix from 3.29.0 to 3.32.0.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Update removeRouteBelow signature for Flutter 3.32 (#96)

Poem

A hop and a skip, the signature's new,
Flutter 3.32, we now bid adieu
To errors and warnings, the tests all compile,
The navigator’s journey continues in style.
With generics in tow, our code’s up to date—
The rabbit approves, this fix is great! 🐇✨
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df6f210 and 65a558b.

📒 Files selected for processing (1)
  • .github/workflows/main.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/main.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wolfenrain wolfenrain changed the title Support Flutter 3.32.0 feat: support Flutter 3.32.0 May 28, 2025
@wolfenrain
Copy link
Member

Thanks for the PR, this seems to be a more complete version of #94, so thank you for that.

We should bump the version in the workflows as well because that is now failing but aside from that this PR is looking great.

@Conrad598
Copy link
Contributor Author

Conrad598 commented May 28, 2025

We should bump the version in the workflows as well because that is now failing

Done

@marcossevilla
Copy link
Contributor

hey @Conrad598 we can close this PR in favor of #98 since we had a few changes to add additional to yours if that's okay, thanks for your time contributing on this!

@alestiago alestiago mentioned this pull request Jun 3, 2025
7 tasks
@alestiago
Copy link
Contributor

@Conrad598 closing in favor of #98 , however we will add you as a co-author due to the effort you've made in reporting this and raising the Pull Request (hence you will show-up as a mockingjay contributor). Once again, many thanks!

@alestiago alestiago closed this Jun 3, 2025
@Conrad598
Copy link
Contributor Author

I appreciate it @alestiago. Glad I could help. I'm happy to see this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Incompatible with Flutter 3.32.0
4 participants