-
Notifications
You must be signed in to change notification settings - Fork 12
feat: support Flutter 3.32.0 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
""" WalkthroughThe method signature for Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thanks for the PR, this seems to be a more complete version of #94, so thank you for that. We should bump the version in the workflows as well because that is now failing but aside from that this PR is looking great. |
Done |
hey @Conrad598 we can close this PR in favor of #98 since we had a few changes to add additional to yours if that's okay, thanks for your time contributing on this! |
@Conrad598 closing in favor of #98 , however we will add you as a co-author due to the effort you've made in reporting this and raising the Pull Request (hence you will show-up as a mockingjay contributor). Once again, many thanks! |
I appreciate it @alestiago. Glad I could help. I'm happy to see this fixed! |
Status
READY
Description
Fixes #96. This updates the override for
Navigator.removeRouteBelow
for its new signature in Flutter 3.32.0. This also updates the minflutter
version in thepubspec.yaml
to^3.32.0
because the new override would fail to compile on previous versions.Type of Change
Summary by CodeRabbit
Bug Fixes
Tests
Chores