-
Notifications
You must be signed in to change notification settings - Fork 140
Add version of Scala to the output of version command #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1872ae0
to
5816d2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have tests for the version
sub-command, do we?
I think adding one for SIP mode and one for vanilla Scala CLI might be worth it.
Otherwise, LGTM
modules/cli-options/src/main/scala/scala/cli/commands/VersionOptions.scala
Outdated
Show resolved
Hide resolved
cea76b6
to
49f201a
Compare
|
184e009
to
4a17979
Compare
modules/integration/src/test/scala/scala/cli/integration/SipScalaTests.scala
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/SipScalaTests.scala
Show resolved
Hide resolved
a9ad8b7
to
82b77bc
Compare
@tanishiking good catch! We need to adjust to it in Metals before the next release. |
The change in question is in VirtusLab/scala-cli#1262 This change should future proof Metals
The change in question is in VirtusLab/scala-cli#1262 This change should future proof Metals
Does this change makes sense: scalameta/metals#4288 ? |
Or you can use
|
Was |
No, it will be available from |
So it's probably better to just use |
The change in question is in VirtusLab/scala-cli#1262 This change should future proof Metals
I added support for printing info about version of Scala CLI and Scala, the following commands return output:
I skipped added support for printing version for the following command:
now
-v
allows user to increase verbosity, to avoid double meaning of-v
, I skip adding support for this case