Remove ComputeVersion.Command, make ComputeVersion classes positioned #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MaciejG604
force-pushed
the
compute-version-positioned
branch
from
f705437 to
cfdfb92
Compare
lwronski
reviewed
Aug 16, 2023
modules/options/src/main/scala/scala/build/options/ComputeVersion.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
compute-version-positioned
branch
from
cfdfb92 to
9c53e62
Compare
MaciejG604
force-pushed
the
compute-version-positioned
branch
from
9c53e62 to
c878b4d
Compare
lwronski
approved these changes
Aug 17, 2023
MaciejG604
force-pushed
the
compute-version-positioned
branch
from
c878b4d to
d8fe35a
Compare
MaciejG604
force-pushed
the
compute-version-positioned
branch
from
d8fe35a to
a2522fb
Compare
MaciejG604
changed the title
MaciejG604
changed the title
MaciejG604
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ComputeVersion.Command since it may be unsafe.
Add positioning to ComputeVersion instances to be able to point out the erroneous directive.