Skip to content

Support the --test flag with the package sub-command #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Support the --test flag with the package sub-command #3519

merged 1 commit into from
Feb 26, 2025

Conversation

Gedochao
Copy link
Contributor

Fixes #3512

@Gedochao Gedochao force-pushed the feature/package-with-test-scope branch 3 times, most recently from 1f5c875 to f20b145 Compare February 25, 2025 15:31
@Gedochao Gedochao changed the title [WIP] Support the --test flag with the package sub-command Support the --test flag with the package sub-command Feb 25, 2025
@Gedochao Gedochao requested a review from tgodzik February 25, 2025 15:31
@Gedochao Gedochao marked this pull request as ready for review February 25, 2025 15:31
@Gedochao Gedochao force-pushed the feature/package-with-test-scope branch from f20b145 to 8f66b94 Compare February 26, 2025 08:43
@Gedochao Gedochao force-pushed the feature/package-with-test-scope branch from 8f66b94 to dec8986 Compare February 26, 2025 09:50
tgodzik
tgodzik approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 3d6a25e into VirtusLab:main Feb 26, 2025
50 checks passed
@Gedochao Gedochao deleted the feature/package-with-test-scope branch February 26, 2025 14:00
@bishabosha
Copy link
Contributor

bishabosha commented Mar 7, 2025 •
edited
Loading

curious how much closer scala-cli is to full multi module support now? (internally) 🤔

@Gedochao
Copy link
Contributor Author

Gedochao commented Mar 7, 2025 •
edited
Loading

curious how much closer scala-cli is to full multi module support now? (internally) 🤔

When --test gets migrated to SharedOptions (after I get it supported in all build sub-commands), technically speaking, it would become easier to add new scopes, which could then function as virtual modules, being inter-dependent.

Doing so would make it way more complex than we want it, however.
Adding multi-module support isn't on the roadmap right now.
And if we were to add it in the future, it'd likely be in a separate tool dependent on Scala CLI, rather than within the CLI itself, that part hasn't changed.

That being said, if you want to ride my recent efforts towards --test being supported in all project-building sub-commands and hack something yourself... I'd wait until publish and bsp support it. (which hopefully will be ready by v1.8)

@bishabosha
Copy link
Contributor

That being said, if you want to ride my recent efforts towards --test being supported in all project-building sub-commands and hack something yourself... I'd wait until publish and bsp support it. (which hopefully will be ready by v1.8)

cool!

Mee-Tree pushed a commit to Mee-Tree/scala-cli that referenced this pull request Mar 21, 2025
@Gedochao @Mee-Tree
Support the --test flag with the package sub-command (VirtusLab#3519
8cbd827 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the --test option for package
3 participants
@Gedochao @bishabosha @tgodzik