major!: Standardise variable names from central source #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the way snippet variables are loaded and their names. Not only are the names now standardised based on product for consistency with other SDK / cURL snippets, but also declared in a single place rather than loaded individually each file. Whilst this requires eager initialisation and all variables to be declared to run any single snippet, it simplifies management of variables as they are all located in a single file, just as in the Kotlin SDK code snippets. Here the
com.vonage.quickstart.Utilclass is reused to load the variables, again using the dotenv plugin to load this from the.envfile.