-
Notifications
You must be signed in to change notification settings - Fork 60
updating plugin introduction #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mahfuza <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: In this pull request, there are multiple patches that update the introduction to the WasmEdge Plug-in System and provide more details about its architecture, usages, and benefits. These changes enhance understanding and provide valuable additional information about WasmEdge plugins. The patches seem to be mostly additions of new content, but it may be important to verify if any important information has been omitted or if there are inconsistencies with the existing content. Additionally, there is a patch that adds various new packages and another patch that removes the mermaid dependency. The removal of the mermaid dependency should be confirmed for its intention and if all necessary changes have been made to handle its absence. DetailsCommit 1552fd4f7fa9696f4cfd32fc18276d5aa9d20433Key Changes:
Potential Problems:
Overall, the changes in this patch enhance the understanding of the WasmEdge Plug-in System and provide more details about its usages and benefits. Commit 01233502b7677b111571ca4fbe86ca164504ff11Key changes:
Potential problems:
Overall, the changes seem to be providing valuable additional information about WasmEdge plugins and their applications. Commit fc3af9faa65ec1a5b21fa2c91948e9687dc096c0Key changes:
Potential problems:
Commit cc0d6cc51ec62321eb33a92e30742ed9eb98c6dfKey Changes:
Potential Problems:
Commit db6ed5194267d481a147ab73967fc4c746de635dKey changes:
Potential problems:
Overall, the patch seems to be a straightforward removal of the mermaid dependency. It would be good to communicate with the contributor to confirm the reasons for removing the dependency and to ensure that all necessary changes and tests have been carried out. |
@alabulei1 CI Workflows need your approval to run. Its a default feature of GH Actions. More Info: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
Signed-off-by: Mahfuza <[email protected]>
Signed-off-by: Mahfuza <[email protected]>
Signed-off-by: Mahfuza <[email protected]>
Hi @mhmohona Sorry for my delay. Could you please fix the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhmohona Could you please address the above comment?
Signed-off-by: Mahfuza <[email protected]>
Explanation
Updated plugin PR adding more info about
Related issue -
#85
Reopening PR #84 for passing DOC test
What type of PR is this
/kind documentation
Proposed Changes