finalize: Strip "em_js" named data segment. #3553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_em_js_section
branch
from
f1d4d65 to
3677ee8
Compare
sbc100
force-pushed
the
remove_em_js_section
branch
7 times, most recently
from
5afa64c to
52441fb
Compare
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
force-pushed
the
remove_em_js_section
branch
from
52441fb to
01b115a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we find a data segment with the name "em_js", strip it from the
binary. Even in debug mode the names given to data segments by clang
will always start with ".data." or ".rodata" so there is no risk of
normal data ending up in a section with this name.
See: emscripten-core/emscripten#13443