Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

Fix variable names in memory.init execution #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fitzgen
Copy link
Contributor

@fitzgen fitzgen commented Mar 9, 2020

The values popped from the stack were named cnt, src, and dst but then later referred to as n, s, and d respectively. I've updated all uses to the names given when popped from the stack.

The values popped from the stack were named `cnt`, `src`, and `dst` but then later referred to as `n`, `s`, and `d` respectively. I've updated all uses to the names given when popped from the stack.
@binji
Copy link
Member

binji commented Mar 10, 2020

I think @rossberg preferred the single letter names; in particular, ISTR without them you need to bracket the letters (or they'll be interpreted as implicit multiplication). In any case, these are the only places in the file where cnt, dst and src are used.

@nomeata
Copy link
Contributor

nomeata commented May 25, 2020

https://webassembly.github.io/bulk-memory-operations/core/exec/instructions.html#exec-memory-init is currently inconsistent. Looks like someone needs to make a convicing call which names to use.

@rossberg
Copy link
Member

@nomeata, the spec doc on this proposal is inconsistent in a number of ways, due to its circular dependency with the reference types proposal. This should be rectified in the ref types spec draft, which includes this one (at some point backporting clean-ups became too much effort).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants