Reorganise opcode space #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
binji
reviewed
Oct 20, 2016
| | `i32.or` | `0x72` | | | | ||
| | `i32.xor` | `0x73` | | | | ||
| | `i32.shl` | `0x74` | | | | ||
| | `i32.shr_u` | `0x75` | | | |
There was a problem hiding this comment.
the doc has i32.shr_s before i32.shr_u (which is consistent with the rest of the ops)
binji
reviewed
Oct 20, 2016
| | `i64.or` | `0x84` | | | | ||
| | `i64.xor` | `0x85` | | | | ||
| | `i64.shl` | `0x86` | | | | ||
| | `i64.shr_u` | `0x87` | | | |
KarlSchimpf
reviewed
Oct 20, 2016
| @@ -425,18 +425,16 @@ It is legal to have several entries with the same type. | |||
| | Name | Opcode | Immediates | Description | | |||
| | ---- | ---- | ---- | ---- | | |||
| | `unreachable` | `0x00` | | trap immediately | | |||
| | `block` | `0x01` | sig : `inline_signature_type` | begin a sequence of expressions, yielding 0 or 1 values | | |||
There was a problem hiding this comment.
This doesn't match your "alternative opcode proposal". BLock has value 0x2 (nop is 0x1).
There was a problem hiding this comment.
Hm, this is a - line in the diff?
titzer
reviewed
Oct 21, 2016
| @@ -515,132 +523,154 @@ natural alignment. The bits after the | |||
| `log(memory-access-size)` least-significant bits must be set to 0. These bits are reserved for future use | |||
| (e.g., for shared memory ordering requirements). | |||
|
|
|||
| ## Simple operators ([described here](Semantics.md#32-bit-integer-operators)) | |||
| ## Basic operators ([described here](Semantics.md#constants)) | |||
There was a problem hiding this comment.
Done (just "Constants")
|
lgtm other than nit |
This was referenced Oct 21, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as shown here: https://docs.google.com/spreadsheets/d/1RglIQM97cP83Sy-J3BT3D7IxdcH3QCKftiM1bjOL2vc