Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

[Interpreter] infrastructure #138

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Conversation

penzn
Copy link
Contributor

@penzn penzn commented Nov 12, 2019

Provide a buildable skeleton for the interpereter, with end-to end
types, but with lots of gaps in functionality. Unimplemented functions
throw "TODO v128" error; can parse v128 local type and nothing more.

Provide a buildable skeleton for the interpereter, with end-to end
types, but with lots of gaps in functionality. Unimplemented functions
throw "TODO v128" error; can parse `v128` local type and nothing more.
@penzn
Copy link
Contributor Author

penzn commented Nov 12, 2019

@ngzhian let's join forces if you are still interested in the interpreter.

@ngzhian
Copy link
Member

ngzhian commented Nov 12, 2019

Cool! I have been hacking a bit at the interpreter too, but haven't cleaned it up enough to put up a PR. We went for similar implementation to use Bytes. I've implemented a bit of the parsing for v128.const so it at least chugs through simd_const.wast test case.

ngzhian@d86bf00

@penzn
Copy link
Contributor Author

penzn commented Nov 15, 2019

@ngzhian, I just noticed the link to your change, the frontend part looks good, may be we can merge it together with this one somehow.

CC/FYI @rossberg, as we are hacking at the interpreter.

@ngzhian
Copy link
Member

ngzhian commented Nov 15, 2019

I think after this is merged I can try to rebase the frontend changes from my patch. That way there is less code to review in each change.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Use `vxxx` to denote vector type in the lexer.
@penzn
Copy link
Contributor Author

penzn commented Nov 18, 2019

I think after this is merged I can try to rebase the frontend changes from my patch. That way there is less code to review in each change.

const is needed in order to verify other functionality. Let me know if you need help with the change.

I opened #141 to track progress of adding the interpreter.

@arunetm @dtig should we merge this?

@arunetm arunetm merged commit ac82e16 into WebAssembly:master Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants