This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Fixed multiple tables error in simd_const.wast #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed @binji's comment at WebAssembly#132 (comment)
Honry
referenced
this pull request
Mar 11, 2020
New tests for 64x2 constant and more literal testing per WAVM/WAVM#195
|
@binji, PTAL. Thanks! |
binji
approved these changes
Mar 11, 2020
| (call_indirect (type $sig2) | ||
| (v128.const i64x2 0 1) (v128.const i64x2 0 1) (v128.const i64x2 0 1) (i32.const 0) | ||
| (call_indirect (type $sig) | ||
| (v128.const i64x2 0 1) (v128.const i64x2 0 1) (v128.const i64x2 0 1) (i32.const 1) |
There was a problem hiding this comment.
Ah, I forgot about changing the index too. Thanks for checking!
|
LGTM |
Honry
added a commit
to Honry/WAVM
that referenced
this pull request
Mar 16, 2020
tests are pulled from WebAssembly/simd#204
AndrewScheidecker
pushed a commit
to WAVM/WAVM
that referenced
this pull request
Mar 17, 2020
tests are pulled from WebAssembly/simd#204
|
@arunetm, could you help merge it? Since it's been approved but still open for a while. |
|
Thanks @Honry |
kenohassler
pushed a commit
to fgsect/WAFL
that referenced
this pull request
Oct 18, 2021
tests are pulled from WebAssembly/simd#204
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed @binji's comment at #132 (comment)