This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Run simd test cases with make partest #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We list all simd test cases in simd/* in TESTFILES, then tweak the substitution in quiettest to strip quiettest/ from the front of the target, rather than match on just the file name (which loses the simd/) prefix. The temp output file name is unchanged, it uses the base file name (no simd/ prefix).
rossberg
approved these changes
Feb 3, 2021
Co-authored-by: Andreas Rossberg <[email protected]>
ngzhian
added a commit
to ngzhian/simd
that referenced
this pull request
Feb 5, 2021
Follow-up to WebAssembly#434. Now `make partest && make partest` shouldn't fail.
|
Just realized something incorrect about this, if you run |
ngzhian
added a commit
that referenced
this pull request
Feb 9, 2021
* Skip _output directory when listing wast files for test. Follow-up to #434. Now `make partest && make partest` shouldn't fail. * Use a simpler glob Co-authored-by: Andreas Rossberg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We list all simd test cases in simd/* in TESTFILES, then tweak the
substitution in quiettest to strip quiettest/ from the front of the
target, rather than match on just the file name (which loses the simd/)
prefix.
The temp output file name is unchanged, it uses the base file name (no
simd/ prefix).