Skip to content

Commit 85b562c

Browse files
authored
Fix error in Web embedding desc for atomic.notify (#185)
In #110 we changed the `count` argument of `atomic.notify` so that it is treated as an unsigned `i32`. Previous to this change, it was interpreted as a signed `i32`, with negative numbers signalling that all threads should be woken. This part of the overview wasn't fully updated - fixing this now.
1 parent 0d115b4 commit 85b562c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

proposals/threads/Overview.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,8 +436,7 @@ For the web embedding, `memory.atomic.notify` is equivalent in behavior to execu
436436
1. Let `memory` be a `WebAssembly.Memory` object for this module.
437437
1. Let `buffer` be `memory`([`Get`][](`memory`, `"buffer"`)).
438438
1. Let `int32array` be [`Int32Array`][](`buffer`).
439-
1. Let `fcount` be `count` if `count` is >= 0, otherwise ``.
440-
1. Let `result` be [`Atomics.notify`][](`int32array`, `address`, `fcount`).
439+
1. Let `result` be [`Atomics.notify`][](`int32array`, `address`, `count`).
441440
1. Return `result` converted to an `i32`.
442441

443442
## Fence operator

0 commit comments

Comments
 (0)