Fix error in Web embedding desc for atomic.notify #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: WebAssembly/binaryen#4393 In #110 we changed the `count` argument of `atomic.notify` so that it is treated as an unsigned `i32`. Previous to this change, it was interpreted as a signed `i32`, with negative numbers signalling that all threads should be woken. This part of the overview wasn't fully updated - fixing this now.
conrad-watt
changed the title
rossberg
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: WebAssembly/binaryen#4393
In #110 we changed the
countargument ofatomic.notifyso that it is treated as an unsignedi32. Previous to this change, it was interpreted as a signedi32, with negative numbers signalling that all threads should be woken. This part of the overview wasn't fully updated - fixing this now.