[interpreter] implement atomic.fence, add wait/notify edge case tests #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conrad-watt
changed the title
conrad-watt
force-pushed
the
more_tests_1
branch
from
c292b1b to
3537229
Compare
rossberg
reviewed
Oct 4, 2022
| let mem = memory frame.inst (0l @@ e.at) in | ||
| let addr = I64_convert.extend_i32_u i in | ||
| (try | ||
| check_align addr ty sz e.at; |
There was a problem hiding this comment.
Shouldn't this symmetrically require shared as well?
There was a problem hiding this comment.
Currently we allow notify on unshared memory. It's only wait that's disallowed (see also #191).
Co-authored-by: Andreas Rossberg <[email protected]>
|
I can’t tell you how thrilled I am to see this have progress |
|
@rossberg friendly ping |
rossberg
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.