WIP change to use resources #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricochet
commented
Nov 3, 2023
|
|
||
| write-body-sync: func(value: outgoing-value-body-sync) -> result<_, error>; | ||
| write-body-async: func() -> result<outgoing-value-body-async, error>; | ||
| } | ||
| type outgoing-value-body-async = output-stream; |
There was a problem hiding this comment.
More work is needed here to support streams correctly
Mossaka
reviewed
Nov 3, 2023
| @@ -16,28 +16,28 @@ interface cache { | |||
|
|
|||
| // The `get` operation returns the value passed by a previous `set` for the | |||
| // same key within the given TTL or none if there is no such value. | |||
| get: func(k: key) -> future-get-result; | |||
| get: func(k: key) -> borrow<future-get-result>; | |||
There was a problem hiding this comment.
Would it make sense to return an owned future-get-result resource here for consuming?
| @@ -46,14 +46,14 @@ interface cache { | |||
| // value is updated in-place. In the common case of computing and caching a | |||
| // value if the given key is not already in the cache, consider using | |||
| // `get-or-set` (below) intead of separate `get` and `set` operations. | |||
| set: func(k: key, v: outgoing-value, TTL-ms: option<u32>) -> future-result; | |||
| set: func(k: key, v: outgoing-value, TTL-ms: option<u32>) -> borrow<future-result>; | |||
|
Hey @ricochet , I'd love to see this PR being merged. Is there anything blocking at the moment? I would like to offer help to move this forward. |
|
superseded by #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.