Update with the new ctor syntax #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes WebAudio#2051. There are still issues with bikeshed and the webidl parser, but it's largely there. In particular, arguments don't work yet.
|
I don't think we should land this until the bikeshed issues are fixed. It's really nice to have the table of the arguments contain the actual type and whether it is nullable or optional. |
padenot
force-pushed
the
2051-update-ctor-webidl
branch
from
c0e660c to
073f55a
Compare
|
Bikeshed has been updated, and the above has been fixed. |
|
Preview looks good for the few items I checked. Lgtm. |
rtoy
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2051.
There are still issues with bikeshed and the webidl parser, but it's largely there. In particular, arguments don't work yet, and method referencing seems buggy as well. I'll investigate later.
Preview | Diff