Use the node:18-bullseye image for Linux x64 builds
#1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes WiseLibs#1348 by building the artifacts on a base Linux image with glibc 2.31.
mceachen
approved these changes
Mar 17, 2025
ArGeoph
pushed a commit
to ArGeoph/better-sqlite3
that referenced
this pull request
Mar 21, 2025
This fixes WiseLibs#1348 by building the artifacts on a base Linux image with glibc 2.31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1348 by building the artifacts on a base Linux image with
glibc2.31.I still don't like this because the build script has become a mess trying to keep backward compatibility alive. It's pretty difficult to maintain now. But there's no alternative I guess. 🤷🏻♂️
Here's a test artifact built using this container for reference. It's for Node v22. I suggest testing this.
better-sqlite3-v11.9.0-node-v127-linux-x64.tar.gz
Side note:
Now that native arm Linux runners are available, we can switch to them for much faster testing and building. I almost crammed that update into this same PR but decided not to since there are still some limitations to the native arm runners. We can keep that for a future conversation.