-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XLS-74d and XLS-75d: Account Permissions #257
base: master
Are you sure you want to change the base?
Conversation
### 4.2. Failure Conditions | ||
|
||
* The `Account` hasn't authorized the `Delegate` to send transactions on behalf of it. | ||
* The `Account` hasn't authorized the `Delegate` to send this particular transaction type/granular permission on behalf of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to add another failure condition:
When the Account
is the same as Delegate
, will get temBAD_SIGNER
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
### 3.2. Failure Conditions | ||
|
||
* `Permissions` is too long (the limit is 10), or includes duplicates. | ||
* Any of the specified permissions are invalid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to add another failure condition:
When the Account
is same as Delegate
, will get temMALFORMED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|
||
### 4.3. State Changes | ||
|
||
The transaction succeeds, and the fee is charged to the `Delegate` account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, when a transaction is sent by a delegated account without the necessary permissions, it results in a tecNO_PERMISSION
error. tec
error still charges the fee from the delegated account even the transaction does not succeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this section only addresses possible state changes from successful transactions.
Delegate: "rKYLIE......" | ||
} | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to add a situation for multi sign:
for example, alice gives bob TrustSet permission, bob sends TrustSet on behalf of alice but this delegation transaction is multisigned by bob's multi signers.
Destination: "rCHARLIE......", | ||
Delegate: "rALICE......" | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although mentioned before, maybe add a short description saying that alice initiates the transaction and it will use alice's secret.
No description provided.