Skip to content

Do you accept contribution to increase the version to 3.21.9? #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dankeboy36 opened this issue Oct 28, 2022 · 1 comment · Fixed by #7
Closed

Do you accept contribution to increase the version to 3.21.9? #4

dankeboy36 opened this issue Oct 28, 2022 · 1 comment · Fixed by #7

Comments

@dankeboy36
Copy link
Contributor

Thanks for the great lib! I have been using it for a long time, but I must switch to a more recent version of protoc.
@YePpHa
Copy link
Owner

YePpHa commented Oct 28, 2022

Sure, you're welcome to make a PR.

dankeboy36 added a commit to dankeboy36/node-protoc that referenced this issue Oct 29, 2022
@dankeboy36
feat: Updated protoc to 3.20.3
b5cce9f 
`protoc-gen-js` was removed in more recent version of Protocol Buffers.
Ref: protocolbuffers/protobuf-javascript#127

Closes YePpHa#4

Signed-off-by: dankeboy36 <[email protected]>
@dankeboy36 dankeboy36 mentioned this issue Oct 29, 2022
Merged
@YePpHa YePpHa closed this as completed in #7 Oct 29, 2022
YePpHa pushed a commit that referenced this issue Oct 29, 2022
@dankeboy36
feat: Updated protoc to 3.20.3 (#7)
5a2bef5 
`protoc-gen-js` was removed in more recent version of Protocol Buffers.
Ref: protocolbuffers/protobuf-javascript#127

Closes #4

Signed-off-by: dankeboy36 <[email protected]>

Signed-off-by: dankeboy36 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Updated protoc to 3.20.3 dankeboy36/node-protoc
2 participants
@YePpHa @dankeboy36