Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor various detectors to use RegexBasedDetector #103

Merged
merged 6 commits into from
Dec 18, 2018
Merged

refactor various detectors to use RegexBasedDetector #103

merged 6 commits into from
Dec 18, 2018

Conversation

joshuarli
Copy link
Contributor

Follow up to the RegexBasedDetector implemented in #100.

@KevinHock
Copy link
Collaborator

Let's merge in #86 before this one

@joshuarli
Copy link
Contributor Author

joshuarli commented Dec 18, 2018

If that's done, then the changes to KeywordDetector in this branch should be discarded.

Edit: #86 might take a while, so just gonna go ahead and do that so this can be merged before that with minimal conflict.

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KevinHock KevinHock merged commit 66bfb4c into Yelp:master Dec 18, 2018
@joshuarli joshuarli deleted the refactor-detectors branch December 18, 2018 21:24
@domanchi
Copy link
Contributor

Fixes #102

Nirali-ncgm pushed a commit to Nirali-ncgm/detect-secrets that referenced this pull request Apr 4, 2025
…fore-assignment_09072024

add df - cvr_chr_pos -call before using in loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants