Add Stripe detector to plugins #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
KevinHock
approved these changes
May 13, 2019
| secret_type = 'Stripe Access Key' | ||
|
|
||
| blacklist = ( | ||
| # stripe standard keys begin with sk_live and restricted with rk_live |
There was a problem hiding this comment.
I left Stripe in December, so feel free to ignore me ;)
This is accurate in the abstract, depending on what your goals here are (find exploitable credentials vs detect organisational deviation from best practice) you plausibly want to look for sk_test and rk_test as well though. And while I'm opining and since my opinions can no longer be pinned on Stripe, I'm still 100% willing to die on the hill of prefering denylist/allowlist over blacklist/whitelist. lmk if you'd be interested in a PR for that :)
There was a problem hiding this comment.
Thanks for the info, that's a great point! I'd happily accept a PR for that 👍
Signed-off-by: Daniel González Lopes <[email protected]>
|
Thanks! I'll put something together.
…On Mon, May 13, 2019 at 3:03 PM KevinHock ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In detect_secrets/plugins/stripe.py
<#169 (comment)>:
> +"""
+This plugin searches for Stripe keys
+"""
+from __future__ import absolute_import
+
+import re
+
+from .base import RegexBasedDetector
+
+
+class StripeDetector(RegexBasedDetector):
+
+ secret_type = 'Stripe Access Key'
+
+ blacklist = (
+ # stripe standard keys begin with sk_live and restricted with rk_live
Thanks for the info, that's a great point! I'd happily accept a PR for
that 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#169?email_source=notifications&email_token=AADUKAUWX3K5OHQFU6SSOZTPVHQRPA5CNFSM4HMBND32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYPXF2I#discussion_r283555966>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADUKAWBILET43WY5Y6IVWDPVHQRPANCNFSM4HMBND3Q>
.
|
KevinHock
reviewed
May 13, 2019
killuazhu
pushed a commit
to killuazhu/detect-secrets
that referenced
this pull request
Oct 18, 2019
* SoftLayerDetector Detects Softlayer API Keys Supports git-defenders/detect-secrets-discuss#120 * Lines were too long * Address PR comments 1 * Address PR comments 2
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
* SoftLayerDetector Detects Softlayer API Keys Supports git-defenders/detect-secrets-discuss#120 * Lines were too long * Address PR comments 1 * Address PR comments 2
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
* SoftLayerDetector Detects Softlayer API Keys Supports git-defenders/detect-secrets-discuss#120 * Lines were too long * Address PR comments 1 * Address PR comments 2
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
Detects Softlayer API Keys Supports git-defenders/detect-secrets-discuss#120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel González Lopes [email protected]
From paper cited on #159. Supports both standard and restricted keys.