Skip to content

Prometheus Metrics #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Aug 11, 2024
Merged

Prometheus Metrics #1447

merged 27 commits into from
Aug 11, 2024

Conversation

abhinavsingh
Copy link
Owner

@abhinavsingh abhinavsingh commented Aug 11, 2024

  1. Start proxy.py with --enable-metrics flag
  2. Metrics are available at http://localhost:8899/metrics
  3. Use --metrics-path to override endpoint where metrics are exposed, defaults to /metrics
  4. Exposed metrics
# HELP proxypy_work_started_total Total work accepted and started by proxy.py core
# TYPE proxypy_work_started_total counter
proxypy_work_started_total 4.0

# HELP proxypy_work_request_received_total Total work finished sending initial request
# TYPE proxypy_work_request_received_total counter
proxypy_work_request_received_total 2.0

# HELP proxypy_work_finished_total Total work finished by proxy.py core
# TYPE proxypy_work_finished_total counter
proxypy_work_finished_total 2.0

# HELP proxypy_work_active Total work under active execution
# TYPE proxypy_work_active gauge
proxypy_work_active 2.0

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 49.36709% with 80 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (71f3c65) to head (4e0bcfe).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
proxy/core/event/metrics.py 48.64% 36 Missing and 2 partials ⚠️
proxy/http/server/metrics.py 35.29% 33 Missing ⚠️
proxy/common/flag.py 14.28% 4 Missing and 2 partials ⚠️
proxy/http/server/web.py 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1447      +/-   ##
===========================================
- Coverage    84.60%   83.97%   -0.63%     
===========================================
  Files          178      180       +2     
  Lines         8133     8288     +155     
  Branches      1241     1266      +25     
===========================================
+ Hits          6881     6960      +79     
- Misses        1053     1127      +74     
- Partials       199      201       +2     
Flag Coverage Δ
GHA 83.81% <49.36%> (-0.63%) ⬇️
Linux 83.45% <49.36%> (-0.62%) ⬇️
Python 3.10 84.48% <49.36%> (-0.70%) ⬇️
Python 3.11 83.72% <49.36%> (-0.63%) ⬇️
Python 3.12 83.72% <49.36%> (-0.63%) ⬇️
Python 3.6 84.42% <49.36%> (-0.70%) ⬇️
Python 3.7 84.42% <49.36%> (-0.70%) ⬇️
Python 3.8 84.49% <49.36%> (-0.70%) ⬇️
Python 3.9 84.55% <49.36%> (-0.70%) ⬇️
Windows 77.71% <49.36%> (-0.45%) ⬇️
macOS 83.81% <49.36%> (-0.63%) ⬇️
pytest 83.81% <49.36%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinavsingh abhinavsingh merged commit 091ba36 into develop Aug 11, 2024
57 of 58 checks passed
@abhinavsingh abhinavsingh deleted the metrics branch August 11, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Prometheus via plugin
1 participant