Skip to content

[TLSInterception] Fix serial number generation #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2021
Merged

[TLSInterception] Fix serial number generation #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19e6881
Fix serial number generation
abhinavsingh Dec 21, 2021
453736c
Fix spellcheck-doc
abhinavsingh Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proxy/common/backports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def randint(self):
backports
getter
Arndt
del
"""

def __init__(self, ttl: float = 0):
Expand Down
4 changes: 2 additions & 2 deletions proxy/http/proxy/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
'--ca-cert-dir',
type=str,
default=DEFAULT_CA_CERT_DIR,
help='Default: ~/.proxy.py. Directory to store dynamically generated certificates. '
help='Default: ~/.proxy/certificates. Directory to store dynamically generated certificates. '
'Also see --ca-key-file, --ca-cert-file and --ca-signing-key-file',
)

Expand Down Expand Up @@ -730,7 +730,7 @@ def gen_ca_signed_certificate(
ca_key_path = self.flags.ca_key_file
ca_key_password = ''
ca_crt_path = self.flags.ca_cert_file
serial = self.uid
serial = '%d%d' % (time.time(), os.getpid())

# Sign generated CSR
if not os.path.isfile(cert_file_path):
Expand Down