Skip to content

Random Password Generator #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Conversation

sshsrn
Copy link
Contributor

@sshsrn sshsrn commented Jan 1, 2023

Signed-off-by: SRIHARI S [email protected]

Pull Request for Play With Python 💡

Issue Title : Random Password Generator

  • Info about the related issue (Aim of the project) :
  • Name: Srihari S
  • GitHub ID: SSHSRN
  • Email ID: [email protected]
  • Idenitfy yourself: (Mention in which program you are contributing in.) CodePeak-2022

Closes: #81

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Signed-off-by: SRIHARI S <[email protected]>
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect to me. But there is a small typo in the project folder name, it should be, Password Generator instead of password generator. Please do the needful.

@sshsrn

SRIHARI S added 2 commits January 2, 2023 10:20
Signed-off-by: SRIHARI S <[email protected]>
Signed-off-by: SRIHARI S <[email protected]>
@sshsrn
Copy link
Contributor Author

sshsrn commented Jan 2, 2023

I have updated the folder name.
@abhisheks008 Kindly check!

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved and ready to be merged.
@sshsrn

@abhisheks008 abhisheks008 changed the title added password generator Password Generator App Jan 2, 2023
@abhisheks008 abhisheks008 changed the title Password Generator App Random Password Generator Jan 2, 2023
@abhisheks008 abhisheks008 merged commit d4f8cff into abhisheks008:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random Password Generator
2 participants