-
Notifications
You must be signed in to change notification settings - Fork 28
[ECO-5220] Enforce ubuntu-22.04
in CI to support python 3.7
#595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
python 3.7 has reached its end of life [1] and is no longer available for the current latest ubuntu version 24.04 [2], hence the "Version 3.7 was not found in the local cache" error in CI. Enforce ubuntu-22.04 instead of ubuntu-latest so we can test against python 3.7 until we drop support for it in the library. Resolves #585 [1] https://docs.python.org/3.7/whatsnew/3.7.0.html#summary [2] actions/setup-python#962 (comment)
WalkthroughThe pull request updates the GitHub Actions workflow by modifying the runner environment in the Changes
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
python 3.7 has reached its end of life [1] and is no longer available for the current latest ubuntu version 24.04 [2], hence the "Version 3.7 was not found in the local cache" error in CI.
Enforce ubuntu-22.04 instead of ubuntu-latest so we can test against python 3.7 until we drop support for it in the library.
Resolves #585
[1] https://docs.python.org/3.7/whatsnew/3.7.0.html#summary
[2] actions/setup-python#962 (comment)
Summary by CodeRabbit