Prevent duplicated package versions #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any guidance on the failing checks? |
|
@bennati you need to regenerate the test outputs, the dependencies have been updated for the tests so for fixing tests in test_cli use this command: for fixing tests in test_resolution, please compare the changes from the expected output. |
|
@bennati gentle ping! |
The function get_versions_for_package_from_repo might return duplicated package versions in case the specified version is present both as wheel and as sdist package. Duplicated entries cause the package resolution to take longer. The new behavior is that the package version is considered if the package is present as either whel or sdist package. Signed-off-by: Stefano Bennati <[email protected]>
The new dependency tree corresponds to the one generate by pip download --verbose X where X is flask~=2.1.2 and autobahn==22.3.2 respectively. Signed-off-by: Stefano Bennati <[email protected]>
bennati
force-pushed
the
fix-duplicated-package-versions
branch
from
09625b6 to
9383d32
Compare
|
@bennati Thanks! I think the other failures are not yours. But some weird instability. |
Signed-off-by: Tushar Goel <[email protected]>
|
@bennati thank you, I have pushed one minor commit on your branch to update the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function get_versions_for_package_from_repo might return duplicated package versions in case the specified version is present both as wheel and as sdist package.
Duplicated entries cause the package resolution to take longer. The new behavior is that the package version is considered if the package is present as either wheel or sdist package.
Signed-off-by: Stefano Bennati [email protected]