-
Notifications
You must be signed in to change notification settings - Fork 24
Fix missing index_urls parsing (#127) #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing index_urls parsing (#127) #168
Conversation
@unclejay80 thanks++, please have a look on the failing tests and also update the tests https://github.com/nexB/python-inspector/?tab=readme-ov-file#testing and also run |
Hi @TG1999 , thanks for having a look. I just executed |
@unclejay80 please check https://github.com/nexB/python-inspector/?tab=readme-ov-file#testing instructions are given in how to regen tests. |
Signed-off-by: Jürgen Wischer <[email protected]>
c038117
to
94ce45c
Compare
@TG1999 pipelines looks fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@unclejay80 thanks++, merged! |
@TG1999 thank you. any chances to get a release soon to get this also fixed downstream in oss Review toolkit? |
@TG1999 great thanks |
I've recognized that using
requirements.txt
file generated by poetry sometimes start also with:--index-url https://dl-nexus.devopslab.tech/repository/bwmessenger-pypi/simple
With this fix
index-url
will also be parsed and not only--extra-index-urls
so the issue with ort mentioned in #127 could be resolved if this the case.