Skip to content

Fix missing index_urls parsing (#127) #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

unclejay80
Copy link
Contributor

@unclejay80 unclejay80 commented Jan 18, 2024

I've recognized that using requirements.txt file generated by poetry sometimes start also with:
--index-url https://dl-nexus.devopslab.tech/repository/bwmessenger-pypi/simple

With this fix index-url will also be parsed and not only --extra-index-urls so the issue with ort mentioned in #127 could be resolved if this the case.

@TG1999
Copy link
Contributor

TG1999 commented Jan 22, 2024

@unclejay80 thanks++, please have a look on the failing tests and also update the tests https://github.com/nexB/python-inspector/?tab=readme-ov-file#testing and also run make valid for fixing formatting based test failures

@unclejay80
Copy link
Contributor Author

Hi @TG1999 , thanks for having a look. I just executed pytest -vvs on the main branch an this was the result: 18 failed, 148 passed, 1 skipped, 1422 warnings . How should I proceed with this? I can take care that test_requirement_parsing.py is working

@TG1999
Copy link
Contributor

TG1999 commented Jan 23, 2024

@unclejay80 please check https://github.com/nexB/python-inspector/?tab=readme-ov-file#testing instructions are given in how to regen tests.

@unclejay80 unclejay80 force-pushed the fix-requirements-poetry-index-urls branch from c038117 to 94ce45c Compare January 23, 2024 11:52
@unclejay80
Copy link
Contributor Author

@TG1999 pipelines looks fine now

Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TG1999 TG1999 merged commit f868a31 into aboutcode-org:main Jan 25, 2024
@TG1999
Copy link
Contributor

TG1999 commented Jan 25, 2024

@unclejay80 thanks++, merged!

@unclejay80
Copy link
Contributor Author

@TG1999 thank you. any chances to get a release soon to get this also fixed downstream in oss Review toolkit?

@TG1999
Copy link
Contributor

TG1999 commented Feb 10, 2024

@unclejay80
Copy link
Contributor Author

@TG1999 great thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants