generated from aboutcode-org/skeleton
-
Notifications
You must be signed in to change notification settings - Fork 24
Change output format #68 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f9935f
to
9193a5f
Compare
pombredanne
requested changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor nit!
You still need a changelog entry and some doc that explains the new format and its key changes
tests/data/environment-marker-test-requirements.txt-expected.json
Outdated
Show resolved
Hide resolved
Reference: #68 Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
9193a5f
to
c33e256
Compare
pombredanne
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Make write_output sleek by passing output as a parameter instead of computing output in the function Bump the version to 0.7.2 Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 5, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 5, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 10, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 10, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 11, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 11, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #68
Signed-off-by: Tushar Goel [email protected]