Skip to content

Change output format #68 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2022
Merged

Change output format #68 #69

merged 4 commits into from
Oct 5, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Sep 27, 2022

Reference: #68
Signed-off-by: Tushar Goel [email protected]

@TG1999 TG1999 force-pushed the output_format_change branch 5 times, most recently from 8f9935f to 9193a5f Compare September 28, 2022 19:08
@TG1999 TG1999 requested a review from pombredanne September 28, 2022 19:17
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit!
You still need a changelog entry and some doc that explains the new format and its key changes

Reference: #68

Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 force-pushed the output_format_change branch from 9193a5f to c33e256 Compare September 30, 2022 15:07
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

TG1999 added 2 commits October 4, 2022 16:54
Make write_output sleek by passing output as a parameter instead of computing output in the function

Bump the version to 0.7.2

Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 merged commit 70d82f0 into main Oct 5, 2022
mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this pull request Oct 5, 2022
As no dependencies are installed anymore there is no need to create a
virtual environment. The Python binary from the path is now used to get
metadata from setup.py. This might temporarily cause issues if the
setup.py is not compatible with this Python version, but this will soon
be fixed once this data can be retrieved from the python-inspector
output (this will be available once [1] is released).

[1]: aboutcode-org/python-inspector#69

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this pull request Oct 5, 2022
As no dependencies are installed anymore there is no need to create a
virtual environment. The Python binary from the path is now used to get
metadata from setup.py. This might temporarily cause issues if the
setup.py is not compatible with this Python version, but this will soon
be fixed once this data can be retrieved from the python-inspector
output (this will be available once [1] is released).

[1]: aboutcode-org/python-inspector#69

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this pull request Oct 10, 2022
As no dependencies are installed anymore there is no need to create a
virtual environment. The Python binary from the path is now used to get
metadata from setup.py. This might temporarily cause issues if the
setup.py is not compatible with this Python version, but this will soon
be fixed once this data can be retrieved from the python-inspector
output (this will be available once [1] is released).

[1]: aboutcode-org/python-inspector#69

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this pull request Oct 10, 2022
As no dependencies are installed anymore there is no need to create a
virtual environment. The Python binary from the path is now used to get
metadata from setup.py. This might temporarily cause issues if the
setup.py is not compatible with this Python version, but this will soon
be fixed once this data can be retrieved from the python-inspector
output (this will be available once [1] is released).

[1]: aboutcode-org/python-inspector#69

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this pull request Oct 11, 2022
As no dependencies are installed anymore there is no need to create a
virtual environment. The Python binary from the path is now used to get
metadata from setup.py. This might temporarily cause issues if the
setup.py is not compatible with this Python version, but this will soon
be fixed once this data can be retrieved from the python-inspector
output (this will be available once [1] is released).

[1]: aboutcode-org/python-inspector#69

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit to oss-review-toolkit/ort that referenced this pull request Oct 11, 2022
As no dependencies are installed anymore there is no need to create a
virtual environment. The Python binary from the path is now used to get
metadata from setup.py. This might temporarily cause issues if the
setup.py is not compatible with this Python version, but this will soon
be fixed once this data can be retrieved from the python-inspector
output (this will be available once [1] is released).

[1]: aboutcode-org/python-inspector#69

Signed-off-by: Martin Nonnenmacher <[email protected]>
@TG1999 TG1999 deleted the output_format_change branch October 28, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants