Add import_directives #1158
Merged
Add import_directives #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdawgwilk
force-pushed
the
feature/import_directives
branch
2 times, most recently
from
9c7821a to
d4c7a11
Compare
|
What do you think about moving the directive imports to a separate DirectiveImports phase? So each phase does only one thing and makes it easier to remove/change the separate schema phases. Same applies to type_extensions in #1157 btw. Should perhaps also be moved to a separate phase. |
kdawgwilk
force-pushed
the
feature/import_directives
branch
from
d4c7a11 to
ad5c0fb
Compare
|
Alright got that feedback in and pulled that into a new |
|
@kdawgwilk this looks solid, let's rebase on the new master branch that has the formatter changes. |
benwilson512
requested changes
Feb 17, 2022
kdawgwilk
force-pushed
the
feature/import_directives
branch
from
ad5c0fb to
f2756b5
Compare
|
This is now rebased and changelog entry added 👍 |
|
Anything else I should include here? |
|
This is great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some duplication between import_types but this PR is still relatively small so I wasnt sure if I should spend much time refactoring this to reduce some of the duplication
Closes #1152