Order API Method "confirmShipment" throws exception but was successfull #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API Method
confirmShipmentrespond with the HTTP status code 204 = NoContent when a request is successfull:https://developer-docs.amazon.com/sp-api/docs/orders-api-v0-reference#confirmshipment
This response code throws a exception with the message "Amazon Api didn't respond with Okay, see exception for more details".
I added the response Code to the response codes that would be recognized as successfull request.
With this pull request all requests will be successfull when they have a 204 status code. It could also be changed to only allow 204 if the generic type of the method
ExecuteRequestTryisNoContent.