Skip to content

Support for slide links in publication pages #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2024
Merged

Support for slide links in publication pages #2126

merged 2 commits into from
May 17, 2024

Conversation

saravan2
Copy link
Contributor

  1. Introduced slidesurl to encode link for slides
  2. Added optional field : slides_url to markdown_generator/publication. tsv and modified publication.ipynb to parse the optional field and append slidesurl
  3. ipython notebook execution regenerated _publications/*-paper-title-number-{1-3}.md
  4. Updated _includes/archive-single.html and _layouts/single.html to display links to slides when slidesurl is set
  5. Added sample slides in files/*

rjzupkoii
rjzupkoii requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@rjzupkoii rjzupkoii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the pull request with these changes! Having support for slides would be a useful addition to the template, but some changes need to be made in order to bring it into line with how the template works and it's overall design. I've made some comments on the relevant files with the changes that need to be made.

@rjzupkoii rjzupkoii self-assigned this May 16, 2024
@saravan2
Copy link
Contributor Author

Thanks for the review. I added commit ebbb512 with relevant changes.

@rjzupkoii rjzupkoii merged commit 1b2f049 into academicpages:master May 17, 2024
@saravan2
Copy link
Contributor Author

@rjzupkoii There is a typo elseif when it should have been elsif in Line 65 of _includes/archive-single.html in my commit ebbb512

I noticed it when I went through the logs of https://github.com/academicpages/academicpages.github.io/actions/runs/9121047739

I regret my oversight.

@rjzupkoii
Copy link
Collaborator

@saravan2 No worries! I was able to fix it and also tweak things a bit as well.

aaronWool pushed a commit to aaronWool/aaronwool.github.io that referenced this pull request Jul 23, 2024
@saravan2 @aaronWool
Addressed PR academicpages#2126 review comments
f2149e0
yoyolicoris added a commit to iamycy/iamycy.github.io that referenced this pull request Jul 27, 2024
@yoyolicoris @jayrobwilliams
@naveenarun @Mohit-15 @bp-high @amyzlc @bhavberi @rjzupkoii @johnhandleyd @SukkaW @MaxGalindo150 @dgrahn @thiagorr162 @saravan2 @manuelhaussmann @YanY-Henry @zarela
Update to newer version (#2)
61bf7bd 
* Increase font size in code blocks

See academicpages#59

* Adds missing semi-colon

* fix font awesome code icon in syntax box

* Fix encoding issue with bib files

* add goodreads to site

* change orcid color

* add medium icon

* add medium profile

* Resolve Google Scholar link not displayed

There was as slight typo in the logic due to which the google scholar link for the respective author's profile set in Config was not being displayed.

* Adding pronouns field to author profile

* Add Google Analytics 4 Support

* fix: Remove deprecated JavaScript to avoid load error from 404 page

* Update files to be ignored

* + webrick to gem file

* academicpages#1902 RM excerpt in pages

* Start updating the README

* academicpages#456 Use real Google Scholar link as an example

* Update issue templates

* RM minimal mistakes changelog

* academicpages#1906

* Edit readme

* + Syntax highlighting example

* Update README.md

* Update README

* Correct syntax

* Streamline config organization for new users

* Add Mastodon to social media

* Closes academicpages#696 with new Kaggle link

* Adjustments to Kaggle link

* Closes academicpages#271 with addition of arXiv

* academicpages#244, academicpages#1600, academicpages#1917 update font awesome to v6, add icons

* Closes academicpages#1911 with update to Academicons

* Closes academicpages#1671 with a new favicon

* academicpages#462 update inline documentation

* academicpages#1041 allow links to wrap

* Closes academicpages#1773 with update to HTML

* Closes academicpages#45 with an update to the CV generator

* academicpages#33, academicpages#1919 Possible missing template fix, bump MathJax to 3.0

* academicpages#1153 add Zhihu

* Closes academicpages#1905 with updates to documentation

* Closes academicpages#693 with updates to documentation and location of citation

* Closes academicpages#820 with updated style

* added missing spanish translations and updated some of the previous ones on ui-text-yml

* Replace `polyfill.io`

* Closes academicpages#1972, update Markdown documentation

* Closes academicpages#1936 with setting to hide RSS feed

* academicpages#1935 clean-up the footer follow a bit

* RM old development override

* Make it clearer where the footnotes are

* academicpages#1975 ignore files created by npm

* Closes academicpages#339 with a fixed masthead

* academicpages#1975 version updates, manage jQuery from npm

* Closes academicpages#1970 with responsive element

* Fix typo

* Closes academicpages#1999

* scroll in sidebar

* scroll in sidebar

* Add scroll to sidebar and adjust media query for screen adaptability

* Closes academicpages#2029 with update to sidebar

* Closes academicpages#1917 with with icon, FA bump to 6.5.2

* academicpages#2061 Update README with note on dependencies

* Closes academicpages#2055 with adjustment to masthead-height

* Adjust variable name to prevent confusion

* Update casing of template name

* Fix typo in build-essential package name.

The package which is required for this installation is named `build-essential`, not `build-essentials`.

* Fix academicpages#1920 by allowing text to wrap

* Add support to semantic scholar in author profile

* Support for displaying slides on publication pages

* Addressed PR academicpages#2126 review comments

* Fix typo, modifications to style

* Update _config.yml

Make claimed default and actual default consistent

* Add Chinese (both simplified and traditional) to ui-text.yml

Simplified Chinese:
  zh
  zh-CN

Traditional Chinese:
  zh-HK
  zh-TW

* Adds commands for MacOS

* Update README.md

* update about me

* use shorter QMUL

* delete template file

---------

Co-authored-by: Steve <[email protected]>
Co-authored-by: Rob Williams <[email protected]>
Co-authored-by: sigma67 <[email protected]>
Co-authored-by: naveenarun <[email protected]>
Co-authored-by: Mohit_Gupta <[email protected]>
Co-authored-by: Bhavish Pahwa <[email protected]>
Co-authored-by: amyzlc <[email protected]>
Co-authored-by: Sonny Arora <[email protected]>
Co-authored-by: Bhav Beri <[email protected]>
Co-authored-by: rjzupkoii <[email protected]>
Co-authored-by: johnhandleyd <[email protected]>
Co-authored-by: SukkaW <[email protected]>
Co-authored-by: Maximiliano <[email protected]>
Co-authored-by: Dan Grahn <[email protected]>
Co-authored-by: Dan Grahn <[email protected]>
Co-authored-by: thiagorr162 <[email protected]>
Co-authored-by: Saravanan D. <[email protected]>
Co-authored-by: Manuel Haussmann <[email protected]>
Co-authored-by: Yuhang YAN (Henry) <[email protected]>
Co-authored-by: Zarela <[email protected]>
yoyolicoris added a commit to iamycy/iamycy.github.io that referenced this pull request Oct 7, 2024
@yoyolicoris @jayrobwilliams
@naveenarun @Mohit-15 @bp-high @amyzlc @bhavberi @rjzupkoii @johnhandleyd @SukkaW @MaxGalindo150 @dgrahn @thiagorr162 @saravan2 @manuelhaussmann @YanY-Henry @zarela @02hyc @edbrito-swdev @abcsds @Samir-Rashid @c-martinez @x-zang @zoelesv
sync with upstream (#3)
8a8412a 
* Increase font size in code blocks

See academicpages#59

* Adds missing semi-colon

* fix font awesome code icon in syntax box

* Fix encoding issue with bib files

* add goodreads to site

* change orcid color

* add medium icon

* add medium profile

* Resolve Google Scholar link not displayed

There was as slight typo in the logic due to which the google scholar link for the respective author's profile set in Config was not being displayed.

* Adding pronouns field to author profile

* Add Google Analytics 4 Support

* fix: Remove deprecated JavaScript to avoid load error from 404 page

* Update files to be ignored

* + webrick to gem file

* academicpages#1902 RM excerpt in pages

* Start updating the README

* academicpages#456 Use real Google Scholar link as an example

* Update issue templates

* RM minimal mistakes changelog

* academicpages#1906

* Edit readme

* + Syntax highlighting example

* Update README.md

* Update README

* Correct syntax

* Streamline config organization for new users

* Add Mastodon to social media

* Closes academicpages#696 with new Kaggle link

* Adjustments to Kaggle link

* Closes academicpages#271 with addition of arXiv

* academicpages#244, academicpages#1600, academicpages#1917 update font awesome to v6, add icons

* Closes academicpages#1911 with update to Academicons

* Closes academicpages#1671 with a new favicon

* academicpages#462 update inline documentation

* academicpages#1041 allow links to wrap

* Closes academicpages#1773 with update to HTML

* Closes academicpages#45 with an update to the CV generator

* academicpages#33, academicpages#1919 Possible missing template fix, bump MathJax to 3.0

* academicpages#1153 add Zhihu

* Closes academicpages#1905 with updates to documentation

* Closes academicpages#693 with updates to documentation and location of citation

* Closes academicpages#820 with updated style

* added missing spanish translations and updated some of the previous ones on ui-text-yml

* Replace `polyfill.io`

* Closes academicpages#1972, update Markdown documentation

* Closes academicpages#1936 with setting to hide RSS feed

* academicpages#1935 clean-up the footer follow a bit

* RM old development override

* Make it clearer where the footnotes are

* academicpages#1975 ignore files created by npm

* Closes academicpages#339 with a fixed masthead

* academicpages#1975 version updates, manage jQuery from npm

* Closes academicpages#1970 with responsive element

* Fix typo

* Closes academicpages#1999

* scroll in sidebar

* scroll in sidebar

* Add scroll to sidebar and adjust media query for screen adaptability

* Closes academicpages#2029 with update to sidebar

* Closes academicpages#1917 with with icon, FA bump to 6.5.2

* academicpages#2061 Update README with note on dependencies

* Closes academicpages#2055 with adjustment to masthead-height

* Adjust variable name to prevent confusion

* Update casing of template name

* Fix typo in build-essential package name.

The package which is required for this installation is named `build-essential`, not `build-essentials`.

* Fix academicpages#1920 by allowing text to wrap

* Add support to semantic scholar in author profile

* Support for displaying slides on publication pages

* Addressed PR academicpages#2126 review comments

* Fix typo, modifications to style

* Update _config.yml

Make claimed default and actual default consistent

* Add Chinese (both simplified and traditional) to ui-text.yml

Simplified Chinese:
  zh
  zh-CN

Traditional Chinese:
  zh-HK
  zh-TW

* Adds commands for MacOS

* Update README.md

* academicpages#2316 update padding

* academicpages#2318 updating documentation a bit

* Alphabetize the excludes

* Closes academicpages#48 with a more general and customizable approach

* fix: lastfm url

* Update README.md

* Fixing YouTube URL generation in author-profile.html

YouTube does not use /user/username at the moment. If a person has a YouTube handle, the URL is:
www.youtube.com/@HANDLE

The fix is very minimal but I needed it for my website so I've also added it here.

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* academicpages#1975 cleaning up the gem files a bit

* academicpages#1975 update fitvids to NPM

* academicpages#1975 update magnific-popup to NPM

* academicpages#1975 update smooth scroll to NPM

* Closes academicpages#1975 RM stickyfill in favor of native browser support

* Closes academicpages#2287, academicpages#534 with updates to documentation, better emoji generation

* Add a dockerfile

* Update README.md

* bug: comments appear at bottom of page

* Closes academicpages#146 with information the details HTML tag

* Minor formatting

* Closes academicpages#828 with update to put the pages last update in the footer.

* academicpages#828 different format string

* academicpages#828 adjustments to account for GitHub Pages limitations

* Fix toc crop (academicpages#221)

Fix by @qhuang-math. I have also removed underlining of toc links, which was being overridden by post body css.

* Reduce excessive footer padding

* Fix misalignment of navigation bar with post body

There was a regression in the template updates where the navigation bar no longer aligns with the post left margin at normal viewport.

* Add notebook to fetch publication information from orcid

* Update author-profile.html

improve alignment of "employer" sidebar

* Closes academicpages#2469 with update to only use username

* academicpages#1093 MV notebook to generator directory

* Update Dockerfile

---------

Co-authored-by: Steve <[email protected]>
Co-authored-by: Rob Williams <[email protected]>
Co-authored-by: sigma67 <[email protected]>
Co-authored-by: naveenarun <[email protected]>
Co-authored-by: Mohit_Gupta <[email protected]>
Co-authored-by: Bhavish Pahwa <[email protected]>
Co-authored-by: amyzlc <[email protected]>
Co-authored-by: Sonny Arora <[email protected]>
Co-authored-by: Bhav Beri <[email protected]>
Co-authored-by: rjzupkoii <[email protected]>
Co-authored-by: johnhandleyd <[email protected]>
Co-authored-by: SukkaW <[email protected]>
Co-authored-by: Maximiliano <[email protected]>
Co-authored-by: Dan Grahn <[email protected]>
Co-authored-by: Dan Grahn <[email protected]>
Co-authored-by: thiagorr162 <[email protected]>
Co-authored-by: Saravanan D. <[email protected]>
Co-authored-by: Manuel Haussmann <[email protected]>
Co-authored-by: Yuhang YAN (Henry) <[email protected]>
Co-authored-by: Zarela <[email protected]>
Co-authored-by: Yanchen Huang <[email protected]>
Co-authored-by: edbrito-swdev <[email protected]>
Co-authored-by: Alberto Barradas <[email protected]>
Co-authored-by: Samir Rashid <[email protected]>
Co-authored-by: Carlos Martinez <[email protected]>
Co-authored-by: Xiaofei (Carl) Zang <[email protected]>
Co-authored-by: Zoe <[email protected]>
schanghydro pushed a commit to schanghydro/schanghydro.github.io that referenced this pull request Jan 2, 2025
@saravan2
Addressed PR academicpages#2126 review comments
9c4a2f9
schanghydro pushed a commit to schanghydro/schanghydro.github.io that referenced this pull request Jan 2, 2025
@rjzupkoii
Merge pull request academicpages#2126 from saravan2/slides
39f40b2 
Support for slide links in publication pages
DavidSteeman added a commit to Knevel-Lab/Knevel-Lab.github.io that referenced this pull request Jan 10, 2025
@DavidSteeman @jayrobwilliams
@naveenarun @Mohit-15 @bp-high @amyzlc @bhavberi @rjzupkoii @johnhandleyd @SukkaW @MaxGalindo150 @dgrahn @thiagorr162 @saravan2 @manuelhaussmann @YanY-Henry @zarela @02hyc @edbrito-swdev @abcsds @Samir-Rashid @c-martinez @x-zang @zoelesv @opasche @dtortorella @TankTechnology @mecaneer23 @tomrannosaurus @oikos99
Update pages (#10)
5822fd3 
* Increase font size in code blocks

See academicpages#59

* Adds missing semi-colon

* fix font awesome code icon in syntax box

* Fix encoding issue with bib files

* add goodreads to site

* change orcid color

* add medium icon

* add medium profile

* Resolve Google Scholar link not displayed

There was as slight typo in the logic due to which the google scholar link for the respective author's profile set in Config was not being displayed.

* Adding pronouns field to author profile

* Add Google Analytics 4 Support

* fix: Remove deprecated JavaScript to avoid load error from 404 page

* Update files to be ignored

* + webrick to gem file

* academicpages#1902 RM excerpt in pages

* Start updating the README

* academicpages#456 Use real Google Scholar link as an example

* Update issue templates

* RM minimal mistakes changelog

* academicpages#1906

* Edit readme

* + Syntax highlighting example

* Update README.md

* Update README

* Correct syntax

* Streamline config organization for new users

* Add Mastodon to social media

* Closes academicpages#696 with new Kaggle link

* Adjustments to Kaggle link

* Closes academicpages#271 with addition of arXiv

* academicpages#244, academicpages#1600, academicpages#1917 update font awesome to v6, add icons

* Closes academicpages#1911 with update to Academicons

* Closes academicpages#1671 with a new favicon

* academicpages#462 update inline documentation

* academicpages#1041 allow links to wrap

* Closes academicpages#1773 with update to HTML

* Closes academicpages#45 with an update to the CV generator

* academicpages#33, academicpages#1919 Possible missing template fix, bump MathJax to 3.0

* academicpages#1153 add Zhihu

* Closes academicpages#1905 with updates to documentation

* Closes academicpages#693 with updates to documentation and location of citation

* Closes academicpages#820 with updated style

* added missing spanish translations and updated some of the previous ones on ui-text-yml

* Replace `polyfill.io`

* Closes academicpages#1972, update Markdown documentation

* Closes academicpages#1936 with setting to hide RSS feed

* academicpages#1935 clean-up the footer follow a bit

* RM old development override

* Make it clearer where the footnotes are

* academicpages#1975 ignore files created by npm

* Closes academicpages#339 with a fixed masthead

* academicpages#1975 version updates, manage jQuery from npm

* Closes academicpages#1970 with responsive element

* Fix typo

* Closes academicpages#1999

* scroll in sidebar

* scroll in sidebar

* Add scroll to sidebar and adjust media query for screen adaptability

* Closes academicpages#2029 with update to sidebar

* Closes academicpages#1917 with with icon, FA bump to 6.5.2

* academicpages#2061 Update README with note on dependencies

* Closes academicpages#2055 with adjustment to masthead-height

* Adjust variable name to prevent confusion

* Update casing of template name

* Fix typo in build-essential package name.

The package which is required for this installation is named `build-essential`, not `build-essentials`.

* Fix academicpages#1920 by allowing text to wrap

* Add support to semantic scholar in author profile

* Support for displaying slides on publication pages

* Addressed PR academicpages#2126 review comments

* Fix typo, modifications to style

* Update _config.yml

Make claimed default and actual default consistent

* Add Chinese (both simplified and traditional) to ui-text.yml

Simplified Chinese:
  zh
  zh-CN

Traditional Chinese:
  zh-HK
  zh-TW

* Adds commands for MacOS

* Update README.md

* academicpages#2316 update padding

* academicpages#2318 updating documentation a bit

* Alphabetize the excludes

* Closes academicpages#48 with a more general and customizable approach

* fix: lastfm url

* Update README.md

* Fixing YouTube URL generation in author-profile.html

YouTube does not use /user/username at the moment. If a person has a YouTube handle, the URL is:
www.youtube.com/@HANDLE

The fix is very minimal but I needed it for my website so I've also added it here.

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* academicpages#1975 cleaning up the gem files a bit

* academicpages#1975 update fitvids to NPM

* academicpages#1975 update magnific-popup to NPM

* academicpages#1975 update smooth scroll to NPM

* Closes academicpages#1975 RM stickyfill in favor of native browser support

* Closes academicpages#2287, academicpages#534 with updates to documentation, better emoji generation

* Add a dockerfile

* Update README.md

* bug: comments appear at bottom of page

* Closes academicpages#146 with information the details HTML tag

* Minor formatting

* Closes academicpages#828 with update to put the pages last update in the footer.

* academicpages#828 different format string

* academicpages#828 adjustments to account for GitHub Pages limitations

* Fix toc crop (academicpages#221)

Fix by @qhuang-math. I have also removed underlining of toc links, which was being overridden by post body css.

* Reduce excessive footer padding

* Fix misalignment of navigation bar with post body

There was a regression in the template updates where the navigation bar no longer aligns with the post left margin at normal viewport.

* Add notebook to fetch publication information from orcid

* Update author-profile.html

improve alignment of "employer" sidebar

* Closes academicpages#2469 with update to only use username

* academicpages#1093 MV notebook to generator directory

* Update Dockerfile

* Update archive-single.html

In the "archive-single" include, the "Download" word is repeated twice in the case when only a slidesURL is given. 
An extra paragraph ending is also mistakenly present.

* Add `scopus` in academic websites

* Adjustments to the about

* Close academicpages#2493 Update for Bing crawler

* Update README with example

* Additional pointers for help

* academicpages#2591 clarify URL in config

* Fix typo in Zhihu URL protocol in

* fix: typo

* Update Gemfile

add   gem 'jekyll-redirect-from'

* Update _config.yml

added   - jekyll-redirect-from to plugins and whitelist

* improved link color contrast

changed the links' blue color to a darker shade to meet color contrast (web accessibility) standards

* improved link color contrast (updated color)

updated the link text color from #236070 to #2F7F93 for improved readability and contrast as recommended by the developers

* Add backup of Gemfile and remove two more templates

---------

Co-authored-by: Steve <[email protected]>
Co-authored-by: Rob Williams <[email protected]>
Co-authored-by: sigma67 <[email protected]>
Co-authored-by: naveenarun <[email protected]>
Co-authored-by: Mohit_Gupta <[email protected]>
Co-authored-by: Bhavish Pahwa <[email protected]>
Co-authored-by: amyzlc <[email protected]>
Co-authored-by: Sonny Arora <[email protected]>
Co-authored-by: Bhav Beri <[email protected]>
Co-authored-by: rjzupkoii <[email protected]>
Co-authored-by: johnhandleyd <[email protected]>
Co-authored-by: SukkaW <[email protected]>
Co-authored-by: Maximiliano <[email protected]>
Co-authored-by: Dan Grahn <[email protected]>
Co-authored-by: Dan Grahn <[email protected]>
Co-authored-by: thiagorr162 <[email protected]>
Co-authored-by: Saravanan D. <[email protected]>
Co-authored-by: Manuel Haussmann <[email protected]>
Co-authored-by: Yuhang YAN (Henry) <[email protected]>
Co-authored-by: Zarela <[email protected]>
Co-authored-by: Yanchen Huang <[email protected]>
Co-authored-by: edbrito-swdev <[email protected]>
Co-authored-by: Alberto Barradas <[email protected]>
Co-authored-by: Samir Rashid <[email protected]>
Co-authored-by: Carlos Martinez <[email protected]>
Co-authored-by: Xiaofei (Carl) Zang <[email protected]>
Co-authored-by: Zoe <[email protected]>
Co-authored-by: OPasche <[email protected]>
Co-authored-by: Domenico Tortorella <[email protected]>
Co-authored-by: TankTechnology <[email protected]>
Co-authored-by: Gabriel Natenshon <[email protected]>
Co-authored-by: tomrannosaurus <[email protected]>
Co-authored-by: Paul Chiou <[email protected]>
lucadalzilio pushed a commit to lucadalzilio/lucadalzilio.github.io that referenced this pull request Jan 18, 2025
@saravan2
Addressed PR academicpages#2126 review comments
3396345
lucadalzilio pushed a commit to lucadalzilio/lucadalzilio.github.io that referenced this pull request Jan 18, 2025
@rjzupkoii
Merge pull request academicpages#2126 from saravan2/slides
e5782ce 
Support for slide links in publication pages
cjd04 pushed a commit to cjd04/cjd04.github.io that referenced this pull request Feb 23, 2025
@saravan2
Addressed PR academicpages#2126 review comments
d7669f4
cjd04 pushed a commit to cjd04/cjd04.github.io that referenced this pull request Feb 23, 2025
@rjzupkoii
Merge pull request academicpages#2126 from saravan2/slides
452f68e 
Support for slide links in publication pages
paraskevasleivadaros pushed a commit to paraskevasleivadaros/paraskevasleivadaros.github.io that referenced this pull request Apr 24, 2025
@saravan2 @paraskevasleivadaros
Addressed PR academicpages#2126 review comments
4d72626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzupkoii rjzupkoii rjzupkoii approved these changes

Assignees

@rjzupkoii rjzupkoii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saravan2 @rjzupkoii