Skip to content

General Improvements #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 3, 2023
Merged

General Improvements #70

merged 11 commits into from
Nov 3, 2023

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Nov 2, 2023 •
edited
Loading

General Improvements

This is a classic @GrantBirki drive-by PR 🚗

This pull request does the following:

  • Lightly updates and formats a few existing Actions workflows
  • Adds a new package-check workflow to validate the contents of the dist/ directory have been properly built
  • Uses a .node-version file so that local development and Actions remain on the same pinned version of node
  • Adds status badges to the readme for visual effect ⭐ 🎨

@GrantBirki GrantBirki self-assigned this Nov 2, 2023
@GrantBirki GrantBirki marked this pull request as ready for review November 2, 2023 17:34
@GrantBirki GrantBirki requested review from gr2m, parkerbxyz and a team as code owners November 2, 2023 17:34
@GrantBirki GrantBirki enabled auto-merge (squash) November 2, 2023 17:38
gr2m
gr2m reviewed Nov 2, 2023
View reviewed changes
gr2m
gr2m approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request and all the improvements ✨

@GrantBirki GrantBirki merged commit bb368d6 into main Nov 3, 2023
@GrantBirki GrantBirki deleted the grantbirki-driveby branch November 3, 2023 05:23
@create-app-token-action-releaser
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Yang-33 Yang-33 mentioned this pull request Mar 28, 2025
Merged
parkerbxyz pushed a commit that referenced this pull request Apr 3, 2025
@Yang-33
docs: delete unused badge (#222)
6f3f591 
It seems that there is an unused badge in this repository. This badge
was introduced in
#70, but after
some trial and error, it was removed from the README
(f28f895
in the PR). However, the badge itself was not deleted.

Therefore, this badge appears to be unnecessary. This patch removes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@parkerbxyz parkerbxyz Awaiting requested review from parkerbxyz

Assignees

@GrantBirki GrantBirki

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrantBirki @gr2m