Skip to content

Updates for ada 3.1.2 / version 1.19.0 #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ada_url/ada.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* auto-generated on 2025-02-23 20:08:55 -0500. Do not edit! */
/* auto-generated on 2025-02-25 13:08:18 -0500. Do not edit! */
/* begin file src/ada.cpp */
#include "ada.h"
/* begin file src/checkers.cpp */
Expand Down
25 changes: 12 additions & 13 deletions ada_url/ada.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* auto-generated on 2025-02-23 20:08:55 -0500. Do not edit! */
/* auto-generated on 2025-02-25 13:08:18 -0500. Do not edit! */
/* begin file include/ada.h */
/**
* @file ada.h
Expand Down Expand Up @@ -290,7 +290,8 @@ bool valid_name_code_point(char32_t input, bool first);
ADA_DISABLE_GCC_WARNING("-Wreturn-type") \
ADA_DISABLE_GCC_WARNING("-Wshadow") \
ADA_DISABLE_GCC_WARNING("-Wunused-parameter") \
ADA_DISABLE_GCC_WARNING("-Wunused-variable")
ADA_DISABLE_GCC_WARNING("-Wunused-variable") \
ADA_DISABLE_GCC_WARNING("-Wsign-compare")
#define ADA_PRAGMA(P) _Pragma(#P)
#define ADA_DISABLE_GCC_WARNING(WARNING) \
ADA_PRAGMA(GCC diagnostic ignored WARNING)
Expand Down Expand Up @@ -9226,34 +9227,32 @@ result<std::optional<url_pattern_result>> url_pattern<regex_provider>::match(
// https://github.com/cloudflare/workerd/blob/8620d14012513a6ce04d079e401d3becac3c67bd/src/workerd/jsg/url.c%2B%2B#L2038
protocol = url->get_protocol().substr(0, url->get_protocol().size() - 1);
// Set username to url’s username.
username = std::move(url->get_username());
username = url->get_username();
// Set password to url’s password.
password = std::move(url->get_password());
password = url->get_password();
// Set hostname to url’s host, serialized, or the empty string if the value
// is null.
hostname = std::move(url->get_hostname());
hostname = url->get_hostname();
// Set port to url’s port, serialized, or the empty string if the value is
// null.
port = std::move(url->get_port());
port = url->get_port();
// Set pathname to the result of URL path serializing url.
pathname = std::move(url->get_pathname());
pathname = url->get_pathname();
// Set search to url’s query or the empty string if the value is null.
// IMPORTANT: Not documented on the URLPattern spec, but search prefix '?'
// is removed. Similar work was done on workerd:
// https://github.com/cloudflare/workerd/blob/8620d14012513a6ce04d079e401d3becac3c67bd/src/workerd/jsg/url.c%2B%2B#L2232
if (url->has_search()) {
auto view = url->get_search();
search =
view.starts_with("?") ? url->get_search().substr(1) : std::move(view);
search = view.starts_with("?") ? url->get_search().substr(1) : view;
}
// Set hash to url’s fragment or the empty string if the value is null.
// IMPORTANT: Not documented on the URLPattern spec, but hash prefix '#' is
// removed. Similar work was done on workerd:
// https://github.com/cloudflare/workerd/blob/8620d14012513a6ce04d079e401d3becac3c67bd/src/workerd/jsg/url.c%2B%2B#L2242
if (url->has_hash()) {
auto view = url->get_hash();
hash =
view.starts_with("#") ? url->get_hash().substr(1) : std::move(view);
hash = view.starts_with("#") ? url->get_hash().substr(1) : view;
}
}

Expand Down Expand Up @@ -10479,14 +10478,14 @@ constructor_string_parser<regex_provider>::parse(std::string_view input) {
#ifndef ADA_ADA_VERSION_H
#define ADA_ADA_VERSION_H

#define ADA_VERSION "3.1.1"
#define ADA_VERSION "3.1.2"

namespace ada {

enum {
ADA_VERSION_MAJOR = 3,
ADA_VERSION_MINOR = 1,
ADA_VERSION_REVISION = 1,
ADA_VERSION_REVISION = 2,
};

} // namespace ada
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "ada-url"
version = "1.18.0"
version = "1.19.0"
authors = [
{name = "Bo Bayles", email = "[email protected]"},
]
Expand Down
Loading