Skip to content

Update repo links, split GHA workflows, make Linux wheels more compatible #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,14 @@ jobs:
- name: Install dependencies
run: |
make requirements
- name: Static analysis
if: "matrix.python == '3.8'"
run: |
make check
- name: Build packages
run: |
make package
- name: Repair wheels
if: "matrix.os == 'ubuntu-20.04'"
run: |
pip install -U auditwheel patchelf
auditwheel repair --plat manylinux_2_31_x86_64 --wheel-dir dist dist/ada_url-*linux*.whl
auditwheel repair --plat manylinux_2_24_x86_64 --wheel-dir dist dist/ada_url-*linux*.whl
- name: Run tests
run: |
pip install -e .
Expand Down
34 changes: 34 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Lint

on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- '**.rst'
- 'docs/**'
push:
branches:
- main
paths-ignore:
- '**.rst'
- 'docs/**'

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.8"
- name: Install dependencies
run: |
make requirements
- name: Static analysis
run: |
make check
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
readme_dst = os.path.join(build_dir, 'README.pprst')
shutil.copyfile(readme_src, readme_dst)

project = 'ada-url/python'
project = 'ada-url/ada-python '
copyright = '2023, Ada authors'
author = 'Ada authors'

Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Clone the git repository to a directory for development:

.. code-block:: sh

git clone https://github.com/ada-url/python/ ada_url_python
git clone https://github.com/ada-url/ada-python.git ada_url_python
cd ada_url_python

Create a virtual environment to use for building:
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ classifiers =
Programming Language :: Python :: 3
Programming Language :: Python :: 3 :: Only
project_urls =
homepage = https://github.com/ada-url/python
homepage = https://github.com/ada-url/ada-python

[options]
packages = find:
Expand Down