Skip to content

Version 1.2.0: ada_url to 2.6.5, host_type support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 31, 2023
Merged

Version 1.2.0: ada_url to 2.6.5, host_type support #25

merged 10 commits into from
Aug 31, 2023

Conversation

bbayles
Copy link
Collaborator

@bbayles bbayles commented Aug 28, 2023 •
edited
Loading

This PR:

  • Upgrades to the latest version of ada_url
  • Adds the host_type to the URL class and to the parse_url function output
  • Adds support for the del operator, using the ada_clear_* functions

The Host Type is returned as an IntEnum, whose values can be compared to normal integers.

anonrig
anonrig reviewed Aug 28, 2023
View reviewed changes
@bbayles bbayles changed the title Version 1.2.0: ada_url to 2.6.3, url_host_type support Version 1.2.0: ada_url to 2.6.4, url_host_type support Aug 28, 2023
bbayles
bbayles commented Aug 28, 2023
View reviewed changes
@bbayles bbayles changed the title Version 1.2.0: ada_url to 2.6.4, url_host_type support Version 1.2.0: ada_url to 2.6.4, host_type support Aug 29, 2023
@bbayles bbayles changed the title Version 1.2.0: ada_url to 2.6.4, host_type support Version 1.2.0: ada_url to 2.6.5, host_type support Aug 30, 2023
@bbayles
Copy link
Collaborator Author

bbayles commented Aug 30, 2023

OK, now using version 2.6.5. This should be good to release.

anonrig
anonrig approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bbayles bbayles merged commit 6903e30 into main Aug 31, 2023
@bbayles bbayles deleted the version-1.2.0 branch August 31, 2023 14:32
@bbayles bbayles mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire left review comments

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbayles @lemire @anonrig