Skip to content

feat: add ada_get_schema_type #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat: add ada_get_schema_type #503

merged 2 commits into from
Sep 5, 2023

Conversation

d3lm
Copy link
Contributor

@d3lm d3lm commented Sep 5, 2023

This PR adds a new method to retrieve the schema type. This is needed for ada-url/rust#51.

@d3lm d3lm requested a review from anonrig September 5, 2023 18:23
@d3lm d3lm mentioned this pull request Sep 5, 2023
Merged
3 tasks
@d3lm d3lm requested a review from anonrig September 5, 2023 18:30
@anonrig anonrig merged commit 4c63372 into main Sep 5, 2023
@anonrig anonrig deleted the delm/feat/schema-type branch September 5, 2023 18:55
@bbayles
Copy link

bbayles commented Sep 5, 2023 •
edited
Loading

Should this have been get_scheme_type? The word "schema" isn't in the URL spec.

@anonrig
Copy link
Member

anonrig commented Sep 5, 2023

Yes... @d3lm can you update the function names?

@bbayles bbayles mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d3lm @bbayles @anonrig