Skip to content

Adding ability to skip device probing upon object init. … #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2019

Conversation

osterwood
Copy link
Contributor

Some hardware devices do not respond to these probes, or could be in reset when software object is created. Default behavior is the same (probing occurs).

… devices do not respond to these probes, or could be in reset when software object is created
@ladyada
Copy link
Member

ladyada commented Nov 25, 2019

hiya what hardware devices don't respond? its good to know :)

@osterwood
Copy link
Contributor Author

PCA9536 is one. Doesn't appear to linux's i2cdetect either.

@tannewt
Copy link
Member

tannewt commented Nov 26, 2019

Hi! Would you mind moving the try/except into a separate private method? It'll make the __init__ clearer that way. Please rephrase the existing comment to mention that it's only done when probe is true. Thanks!

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@tannewt tannewt merged commit 29441f2 into adafruit:master Nov 26, 2019
@osterwood osterwood deleted the skip-init-write branch December 16, 2019 17:22
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 19, 2019
Updating https://www.github.com/adafruit/Adafruit_CircuitPython_MCP4728 to 1.0.1 from 1.0.0:
  > Merge remote-tracking branch 'adafruit/master'
  > Fixing CP-isnt-CPython bug

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 1.3.0 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#19 from jerryneedell/jerryn_interrupt
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#17 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 1.2.0 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#33 from jerryneedell/jerryn_interrupt
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#30 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.1.0 from 4.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#36 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#35 from CapableRobot/skip-init-write

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_BLE_Apple_Notification_Center, Adafruit_CircuitPython_BLE_Magic_Light, Adafruit_CircuitPython_Display_Notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants