Skip to content

Examples changes for dynamic display width and height #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2021
Merged

Examples changes for dynamic display width and height #30

merged 2 commits into from
Apr 3, 2021

Conversation

jposada202020
Copy link

As stated in the title. In addition, examples addition to the API readthedocs

@kmatch98
Copy link

kmatch98 commented Apr 1, 2021

Makes sense to me.

@jposada202020
Copy link
Author

@kmatch98 Thanks for reviewing Kmtach :)

Copy link

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these improvements @jposada202020.

I have one small suggestion, but this looks good to me beyond that.

Copy link

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested successfully on:

Adafruit CircuitPython 6.2.0-rc.0 on 2021-04-01; Adafruit PyPortal with samd51j20

@FoamyGuy FoamyGuy merged commit 2c43e36 into adafruit:master Apr 3, 2021
@jposada202020 jposada202020 deleted the dynamic_screen branch April 3, 2021 17:35
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants