Skip to content

fix candidate for an issue of that a font size argument is not passed to the framebuf layer #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

lyusupov
Copy link
Contributor

@lyusupov lyusupov commented Mar 29, 2021

The font size argument is applicable for text method.
However it does not work (for me) because the epd.py does not currently transfer the size argument onto the framebuf display layer for further processing.

UPDATE:
This PR does actually duplicate #42 request.

'size' argument is a 'scale' relative to default '1' value.
Thus:
size=1 - use default (built-in) font size
size=2 - 2x of default size
size=3 - 3x of default size
....

@ladyada ladyada requested a review from makermelissa March 29, 2021 15:46
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you!

@makermelissa makermelissa merged commit 3e1546d into adafruit:master Mar 29, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants