Add booleans for checking if user sets cert/key pair #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

brentru merged 1 commit into adafruit:master from brentru:add-cert-psk-bools

Oct 10, 2019

Member

brentru commented Oct 10, 2019

Instead of exposing setCert/setPSK in nina-fw as commands, I'm adding two booleans to esp32spi.py instead, set_psk/set_crt.

This is for checking if a user has set a certificate and/or psk prior to establishing a connection with a server.


          add set_psk, set_crt for checking if user sets cert/key pair

3ea8a73

brentru requested a review from a team

October 10, 2019 13:42

jerryneedell approved these changes

View reviewed changes

Contributor

jerryneedell left a comment

I can't test this at this time, but the changes look good to me.

brentru merged commit 602250a into adafruit:master

Contributor

jerryneedell commented Oct 10, 2019

Just a thought -- Is there ever a situation where you would want to clear this setting?

Member Author

brentru commented Oct 10, 2019

@jerryneedell Possibly if wifi.connect with an incorrect cert/key pair and fails.

Contributor

jerryneedell commented Oct 10, 2019

ah, but the user can just do that.
x.set_psk = False

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@b2f6591)

ce6e829

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#78 from brentru/add-cert-psk-bools

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.4.0 from 3.3.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#53 from caternuson/spi_neopixel

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.4.2 from 3.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#35 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#34 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#14 from devoh747/devoh747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet