Fix off by 1 error affecting Sparkle and SparkePulse animations #49
Conversation
nnja
force-pushed
the
fix_sparkle_and_sparklepulse_animations
branch
from
bfec5a2 to
a4bb2dd
Compare
| @@ -94,5 +94,6 @@ def draw(self): | |||
| def after_draw(self): | |||
| self.show() | |||
| for pixel in self._pixels: | |||
| self.pixel_object[pixel] = self._half_color | |||
| self.pixel_object[pixel + 1] = self._dim_color | |||
| num_pixels = len(self.pixel_object) | |||
There was a problem hiding this comment.
Maybe move this outside the loop to avoid having to check the length on each iteration? (This should be O(1) but avoiding as many calls as possible in loops is good)
There was a problem hiding this comment.
Good call. Since this value doesn't change during the course of execution I moved it up to the constructor. Let me know if you'd prefer it back in the after_draw method.
nnja
force-pushed
the
fix_sparkle_and_sparklepulse_animations
branch
from
a4bb2dd to
51621ef
Compare
|
The CI failure seems unrelated to my changes. |
There was a problem hiding this comment.
I successfully recreated the issue and tested this fix. Looks good to me, thank you for the fix!
The CI issue is unrelated to this. The fix for it was just recently merged into library. If you can pull in the latest changes and push a commit to this branch I think it should resolve that issue now.
nnja
force-pushed
the
fix_sparkle_and_sparklepulse_animations
branch
from
51621ef to
da0d851
Compare
|
@FoamyGuy I rebased on top of master, looks like that fixed the CI issue 👍 |
|
@FoamyGuy also, do you happen to have any thoughts on the comment I left in the issue? #48 (comment) |
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.4 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#11 from kattni/update-combo-example Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 3.3.2 from 3.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#38 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#37 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.3.3 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#21 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#20 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.3.3 from 2.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#58 from cjsieh/cycle_complete > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#49 from nnja/fix_sparkle_and_sparklepulse_animations
I noticed the following issues with Sparkle animations:
See #48 for details and example code that tests this fix.
Closes #48