Add Missing Type Annotations #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tekktrik merged 2 commits into adafruit:main from tcfranks:main

Jan 16, 2023

Contributor

tcfranks commented Jan 16, 2023

resolves #12
Submitted for review / comment


          Add Missing Type Annotations

576614d

tekktrik requested changes

View reviewed changes

Member

tekktrik left a comment

Couple bits of feedback, but looks great!

adafruit_lsm303_accel.py Outdated Show resolved Hide resolved

adafruit_lsm303_accel.py Outdated Show resolved Hide resolved


          changes per reviewer comments

2ed2f20

tekktrik self-requested a review

January 16, 2023 15:59

tekktrik approved these changes

View reviewed changes

Member

tekktrik left a comment

Nice!

tekktrik merged commit fe7ce5c into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@85a9103)

dce71b8

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.17 from 1.1.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#16 from tcfranks/main
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.1.3 from 7.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#137 from vladak/type_hints_matcher

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet