Lsm6ds refactor #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
requested changes
Jan 15, 2020
adafruit_lsm6ds.py
Outdated
|
|
||
| self._accel_range = AccelRange.RANGE_4G #pylint: disable=no-member | ||
| self._cached_accel_range = self._accel_range |
There was a problem hiding this comment.
I usually have lines like these to set the default values to something more useful, though 250dps should change then as it's already the default.
There was a problem hiding this comment.
self._cached_accel_range = self._accel_range
should be handled within the property/setter right?
There was a problem hiding this comment.
yes, you're right. I misunderstood
There was a problem hiding this comment.
Pylint just reminded me that it doesn't like when you do that because it ends up getting defined outside of __init__
There was a problem hiding this comment.
set it to None at the top of init
adafruit_lsm6ds.py
Outdated
| self._cached_accel_range = self._accel_range | ||
| self._gyro_range = GyroRange.RANGE_250_DPS #pylint: disable=no-member | ||
| self._cached_gyro_range = self._gyro_range |
ladyada
approved these changes
Jan 15, 2020
|
can merge once passing |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 15, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.6.0 from 2.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#47 from makermelissa/marquee > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#49 from makermelissa/matrix_scroll > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#41 from vdehors/master > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#46 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 2.0.0 from 1.0.0: > Update README.rst > Update README.rst > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#2 from adafruit/lsm6ds_refactor > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#1 from adafruit/dherrada-patch-1 > added additional rates & sensor identifier Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#7 from dglaude/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#8 from caternuson/iss2 > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#5 from dglaude/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#4 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.9.4 from 1.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#51 from makermelissa/master > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#50 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.3.3 from 1.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#24 from caternuson/iss23 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_LSM6DS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor makes subclasses for each sensor and pulls unique code into each subclass