Skip to content

Add temperature support #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 25, 2021
Merged

Add temperature support #36

merged 7 commits into from
Apr 25, 2021

Conversation

Ninic0c0
Copy link
Contributor

@Ninic0c0 Ninic0c0 commented Feb 9, 2021

First try to add temperature support.

Please double check formula :)

@tannewt tannewt requested a review from a team February 9, 2021 19:45
@ladyada
Copy link
Member

ladyada commented Feb 9, 2021

@dherrada wanna review this PR? :)

dhalbert
dhalbert approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reformatted with black, and also tested a real sensor. Seems to work fine. I did not test below-zero temperatures, or similar boundary cases.

@jposada202020
Copy link
Contributor

@dhalbert maybe correct this line :)

Adafruit_CircuitPython_LSM6DS/adafruit_lsm6ds/__init__.py

Line 167 in 9c03539

:param address: The I2C slave address of the sensor
. do not want to step in your toes, trying to be helpful :)

@dhalbert
Copy link
Contributor

dhalbert commented Apr 25, 2021 •
edited
Loading

@dhalbert maybe correct this line :)

Adafruit_CircuitPython_LSM6DS/adafruit_lsm6ds/__init__.py

Line 167 in 9c03539

:param address: The I2C slave address of the sensor

. do not want to step in your toes, trying to be helpful :)

Good point, thanks!

@dhalbert dhalbert merged commit 3c0bf24 into adafruit:master Apr 25, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 27, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
bee5532 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#16 from jposada202020/adding_board.I2C_reference
  > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.6 from 1.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#6 from jposada202020/adding_board.I2C_reference
  > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#5 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AM2320 to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_AM2320#20 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.1.0 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#14 from jposada202020/removing_reset_function
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BH1750 to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BH1750#2 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.3.3 from 3.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#41 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.2.8 from 3.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#31 from jposada202020/improving_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#30 from jposada202020/removing_pressure_reading_limitations
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.5 from 1.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#16 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#45 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#12 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.1.7 from 2.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#22 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS18X20 to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS18X20#22 from jposada202020/improving_docs
  > Added note on Raspberry Pi Compatibility
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.6 from 2.4.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#34 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTS221 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTS221#8 from jposada202020/improving_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_HTS221#7 from micglin/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTU21D to 0.10.7 from 0.10.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTU21D#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS2X to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS2X#7 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS35HW#9 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.1.4 from 4.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#36 from Ninic0c0/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR390 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LTR390#4 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.2.8 from 3.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#24 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31856 to 0.9.7 from 0.9.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31856#13 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.2.9 from 2.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#30 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.0.9 from 1.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#9 from jposada202020/correcting_example_name
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4728 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4728#8 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9600 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9600#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.6 from 3.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#28 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90614 to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90614#19 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#17 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.1.8 from 2.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#31 from adafruit/linting
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPRLS to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPRLS#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#8 from jposada202020/adding_board.I2C_reference
  > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#7 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.5.5 from 1.5.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#22 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_PM25 to 2.1.4 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PM25#17 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#14 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#11 from FoamyGuy/pylint_to_precommit

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.3.5 from 2.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#33 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#3 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.6 from 2.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#20 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.3.4 from 3.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#22 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_TC74 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TC74#4 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLA202X to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLA202x#2 from jposada202020/correcting_example_name
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_TLA202x#1 from FoamyGuy/pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TM#4 from jposada202020/correcting_example_name
  > fix spacing
  > Added pylint disable
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_TM#3 from FoamyGuy/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.3.0 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#22 from jposada202020/improving_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#21 from jposada202020/improving_gain_error_code
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.1.7 from 3.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#19 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#15 from BrianPugh/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.4.7 from 1.4.6:
  > Added module docstring
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to 1.3.5 from 1.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#13 from adafruit/linting
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.5.5 from 2.5.4:
  > Moved to generator
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.6.2 from 1.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#37 from makermelissa/main
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#35 from FoamyGuy/fix_spi_init

Updating https://github.com/adafruit/Adafruit_CircuitPython_ServoKit to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ServoKit#28 from jposada202020/correcting_sphinx_reference
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ninic0c0 @ladyada @jposada202020 @dhalbert