Skip to content

Adding support for defining input pin polarity #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 20, 2020
Merged

Adding support for defining input pin polarity #35

merged 6 commits into from
Oct 20, 2020

Conversation

tigershadowclaw
Copy link
Contributor

No description provided.

@tigershadowclaw
Update digital_inout.py
bf94287 
adding support for changing the pin polarity
@tigershadowclaw
Update mcp23017.py
9e411a6 
adding support for change the pin polarity
@tigershadowclaw
Update mcp23017.py
8bc9eb6 
typo
@tigershadowclaw
Update digital_inout.py
9a47133 
missing comma
@tigershadowclaw
Copy link
Contributor Author

Not sure what is failing for whatever "black" is.

@tigershadowclaw tigershadowclaw mentioned this pull request Oct 17, 2020
Closed
@FoamyGuy
Copy link
Contributor

Hi there @ShadowClaw thanks for working on this!

Black is the python code formatter that we use on all of the code in the project. You can learn about how to use it to format the code here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/black

If you run black on the code files and then push a new commit it should resolve that actions check and let you get past it.

@tigershadowclaw
Copy link
Contributor Author

Alright this should be good to go now. Also this has been tested on hardware and confirmed to work.

@tannewt tannewt requested a review from FoamyGuy October 19, 2020 22:13
FoamyGuy
FoamyGuy approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this successfully with a Pi 16x2 LCD with a modified version of one of the examples. These changes don't interfere with anything in that example and the new invert_polarity parameter is working successfully to swap the value to opposite.

@FoamyGuy FoamyGuy merged commit 34b9c1d into adafruit:master Oct 20, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 20, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c01bb3a)
c02052a 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31856 to 0.9.3 from 0.9.2:
  > Update max31856_simpletest.py

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.4.2 from 2.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#35 from shadowclaw/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8591 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#2 from Techwolfy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#3 from Cybot101/sleepy-reset-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.2 from 2.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#93 from eteq/add-init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tigershadowclaw @FoamyGuy