Skip to content

Update mcp9808_simpletest.py #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2020
Merged

Update mcp9808_simpletest.py #20

merged 4 commits into from
Jan 10, 2020

Conversation

signalmeister
Copy link
Contributor

The original example code did not show the syntax for setting up a module with anything other than the default address. While this information is to be found in the object definition document, a simple amendment to the sample code gives the default and an amended address example.

@signalmeister
Update mcp9808_simpletest.py
5d20bb2 
The original example code did not show the syntax for setting up a module with anything other than the default address. While this information is to be found in the object definition document, a simple amendment to the sample code gives the default and an amended address example.
tannewt
tannewt requested changes Sep 30, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Unfortunately, the lint check is unhappy due to the comments at the end of the lines with the object construction. I don't think they are needed because of the comments on the previous lines so I'd suggest removing them.

In the second example constructor I'd also suggest address=0x19 to make it a bit more readable. Thanks!

signalmeister and others added 3 commits October 1, 2019 19:20
@signalmeister
Update mcp9808_simpletest.py
1caf93f 
I am not really sure that I understood your comments being a total novice at this process - I do not know what a lint check being unhappy means.
If there are still issues, can you please let me know and I hope I can understand your special terms.
@kattni
lint, update comments
667b903
@kattni
address change request
5094b67
@kattni
Copy link
Contributor

kattni commented Jan 8, 2020

@tannewt Can you take another look at this? I made the requested changes and cleaned up the update. Thanks!

tannewt
tannewt approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @kattni

@tannewt tannewt merged commit 7b19752 into adafruit:master Jan 10, 2020
@signalmeister
Copy link
Contributor Author

Thanks for taking this up and making it fit for incorporation. Hope I get better doing these in due course!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 23, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@42bfc73)
c20628a 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AM2320 to 1.1.4 from 1.1.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_AM2320#9 from Ferroin/master
  > Merge pull request adafruit/Adafruit_CircuitPython_AM2320#11 from adafruit/dherrada-patch-1
  > Update README.rst
  > Merge pull request adafruit/Adafruit_CircuitPython_AM2320#10 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.0.2 from 2.0.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#15 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#14 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.2.2 from 2.2.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#21 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.1.7 from 1.1.6:
  > update pylint examples directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.2.5 from 1.2.4:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#14 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#11 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.0.2 from 2.0.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#12 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#11 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.0.2 from 2.0.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#15 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#14 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTU21D to 0.9.1 from 0.9.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_HTU21D#7 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_HTU21D#6 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.1.4 from 1.1.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_INA260#8 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_INA260#7 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.5.3 from 2.5.2:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#21 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#20 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS0 to 2.1.3 from 2.1.2:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#16 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#15 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.0.6 from 2.0.5:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#18 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixKeypad to 1.1.5 from 1.1.4:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKeypad#8 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKeypad#7 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.2.3 from 1.2.2:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#23 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4725 to 1.2.1 from 1.2.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4725#11 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4725#10 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.2.4 from 3.2.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#20 from signalmeister/signalmeister-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#22 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#21 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 1.3.2 from 1.3.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#13 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#12 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.2.5 from 1.2.4:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#8 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#7 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.1.6 from 1.1.5:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#10 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#9 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCD8544 to 1.1.2 from 1.1.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_PCD8544#9 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.3.1 from 1.3.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#14 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#13 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Pixie to 1.1.6 from 1.1.5:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_Pixie#14 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_Pixie#13 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.6 from 3.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#60 from cogliano/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 3.0.1 from 3.0.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#17 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 1.3.1 from 1.3.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#21 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.2.6 from 3.2.5:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SD#30 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.1.5 from 1.1.4:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#11 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#10 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.1.5 from 1.1.4:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#10 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#9 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.1.5 from 3.1.4:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#15 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#14 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.2.2 from 0.2.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#14 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#13 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.2.4 from 3.2.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#25 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.2.4 from 1.2.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#18 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#17 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP007 to 2.0.1 from 2.0.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_TMP007#7 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_TMP007#6 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.2.3 from 3.2.2:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#28 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#27 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 4.0.4 from 4.0.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#11 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#10 from kattni/update-example-pi
  > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#9 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.1.7 from 3.1.6:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#13 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.1.5 from 1.1.4:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#10 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#9 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 1.1.4 from 1.1.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#17 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.3.2 from 2.3.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#18 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.2.6 from 1.2.5:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#15 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_BLE_Apple_Media, Adafruit_CircuitPython_NTP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@signalmeister @kattni @tannewt