Skip to content

Allow publishing of bytes messages #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2021
Merged

Allow publishing of bytes messages #84

merged 3 commits into from
Jul 7, 2021

Conversation

PhearZero
Copy link
Contributor

Useful for educational purposes such as serialization/encoding. (protobuf with minipb)

@PhearZero
Allow publishing of bytes messages
f58c62b 
Useful for educational purposes such as serialization/encoding. (protobuf with minipb)
@brentru brentru self-requested a review July 7, 2021 20:08
@brentru
Copy link
Member

brentru commented Jul 7, 2021 •
edited
Loading

@PhearZero This is failing on PyLint, please refer to the guide here to fix it up: https://learn.adafruit.com/improve-your-code-with-pylint

I'll review once it's passing our build CI.

Also - this is for my curiosity - you mention miniPB? Is there a CircuitPython library for this, or are you using MiniPB+MiniMQTT with CPython?

@PhearZero
Copy link
Contributor Author

PhearZero commented Jul 7, 2021 •
edited
Loading

@brentru Sounds good I'll check out the lint error. Using Circuit/MicroPython(Preferably Circuit) to teach my wife about microcontrollers/messaging systems and it's been a great experience so far.

Also - this is for my curiosity - you mention miniPB? Is there a CircuitPython library for this, or are you using MiniPB+MiniMQTT with CPython?

I am using MiniPB + MiniMQTT in CircuitPython and passing a encoded bytes to my fork of MiniMQTT with this commit. For now, I commented out the MicroPython Logger in MiniPB and included the py source directly in my project.

brentru
brentru reviewed Jul 7, 2021
View reviewed changes
@brentru brentru merged commit eccc36f into adafruit:main Jul 7, 2021
@PhearZero PhearZero deleted the patch-1 branch July 7, 2021 22:11
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 17, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@5b7e4de)
874fec5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.3.0 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#7 from ladyada/main
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#6 from lesamouraipourpre/max-size
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305 to 1.2.0 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305#12 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.4.0 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#21 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#15 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.9 from 1.3.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#22 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0398 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0398#11 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#27 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.3.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#10 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1331 to 1.3.0 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1331#14 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1351 to 1.3.0 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#16 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.8 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#11 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#10 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#2 from lesamouraipourpre/ondiskbitmap-changes
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#5 from lesamouraipourpre/ondiskbitmap-changes
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.2.0 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#15 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.0 from 1.4.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#23 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.20.0 from 2.18.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#154 from lesamouraipourpre/refactor

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#20 from lesamouraipourpre/ondiskbitmap-changes
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#19 from lesamouraipourpre/max-size
  > Moved default branch to main

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#36 from lesamouraipourpre/patch-1
  > Moved default branch to main
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#35 from 4dcu-be/master
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.1.0 from 5.0.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#84 from PhearZero/patch-1
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.3.0 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#45 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#43 from FoamyGuy/pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.3.0 from 2.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#23 from lesamouraipourpre/max_size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Pypixelbuf to 2.2.6 from 2.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#32 from dunkmann00/revert-31-slice-fix
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 2.2.0 from 2.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_turtle#24 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Pixelbuf
rtwfroody pushed a commit to rtwfroody/Adafruit_CircuitPython_MiniMQTT that referenced this pull request Sep 18, 2022
@brentru
Merge pull request adafruit#84 from PhearZero/patch-1
99cd90f 
Allow publishing of bytes messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhearZero @brentru