Skip to content

E and T Morse code patterns incorrect #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarkWoodworth opened this issue May 11, 2022 · 1 comment · Fixed by #52
Closed

E and T Morse code patterns incorrect #50

MarkWoodworth opened this issue May 11, 2022 · 1 comment · Fixed by #52
Labels
good first issue Good for newcomers Hacktoberfest DigitalOcean's Hacktoberfest help wanted Extra attention is needed

Comments

@MarkWoodworth
Copy link

It is only a test stub so this is just a quibble, but the Morse demonstration code misstates the codes for E and T. In reality, E is a DIT, and T is a DAH.
@MarkWoodworth
Copy link
Author

Also (again a quibble that is off the real point of the code), the emergency SOS is not the three letters S O S, but is a single character (a prosign) of three dits three dahs three dits with no inter-letter spacing.

@jepler jepler added good first issue Good for newcomers help wanted Extra attention is needed Hacktoberfest DigitalOcean's Hacktoberfest labels Sep 15, 2022
@dhalbert dhalbert linked a pull request Oct 4, 2022 that will close this issue
Fix issue #50 - E is a DIT and T is a DAH #52
Merged
dhalbert added a commit that referenced this issue Oct 4, 2022
@dhalbert
Merge pull request #52 from prcutler/issue50-morse-patterns
4fe48ae 
Fix issue #50 - E is a DIT and T is a DAH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest DigitalOcean's Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #50 - E is a DIT and T is a DAH
2 participants
@jepler @MarkWoodworth