Skip to content

Remove secrets and more #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2025
Merged

Remove secrets and more #137

merged 3 commits into from
Feb 23, 2025

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Feb 22, 2025 •
edited
Loading

Minor updates to remove secrets usage and update keys:

  1. Remove secrets_data as it will be pulled from PortalBase
  2. Update secrets.py comments to settings.toml
  3. Update AIO keys from AIO_* to ADAFRUIT_AIO_*
  4. Update learn links to point to correct page for settings.toml
  5. Fix JSON_URL

Tested both edited examples on a PyPortal running 9.2.4

@justmobilize justmobilize marked this pull request as ready for review February 22, 2025 19:24
@justmobilize
Copy link
Contributor Author

@dhalbert, can't add you as a reviewer. This one is needed before we remove secrets_data from PortalBase

@dhalbert dhalbert self-requested a review February 22, 2025 20:36
@justmobilize justmobilize mentioned this pull request Feb 22, 2025
Merged
@justmobilize
Copy link
Contributor Author

Realized I added vars for AIO that aren't needed in the example. Fixed and ready for review.

dhalbert
dhalbert approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good! I won't retest since you tested exactly the way I would have.

@dhalbert dhalbert merged commit 86168da into adafruit:main Feb 23, 2025
1 check passed
@justmobilize justmobilize deleted the remove-secrets-and-more branch February 23, 2025 02:24
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 23, 2025
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@761055f)
fd2c6a7 
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 7.0.0 from 6.3.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#137 from justmobilize/remove-secrets-and-more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justmobilize @dhalbert